Reduce startup delays due to healthcheck
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a 30s start_period for nfd and mongodb. During the start period, health checks are run every 5s (the default start_interval) which provides faster reaction to restarts. With this improved mechanism, we can also increase the regular health check interval for nfd to 1 minute to further reduce the overhead.
|
|
Any comments? |
|
LGTM, thanks. The master healthcheck is somewhat of a hack, to wait for the init script to finish creating the "initialized" file. |
pulsejet
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a 30s
start_periodfor nfd and mongodb. During the start period, health checks are run every 5s (the defaultstart_interval) which provides faster reaction to restarts.With this improved mechanism, we can also increase the regular health check interval for nfd to 1 minute to further reduce the overhead.
Please note that this is completely untested.