Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: move state vector to App Parameter #26

Merged
merged 9 commits into from
Jan 6, 2025
Merged

v2: move state vector to App Parameter #26

merged 9 commits into from
Jan 6, 2025

Conversation

pulsejet
Copy link
Collaborator

No description provided.

@yoursunny
Copy link
Member

This PR involves a wire format change.
The protocol specification must be first updated with the proposed change.

@pulsejet
Copy link
Collaborator Author

pulsejet commented Jan 9, 2024

@pulsejet pulsejet force-pushed the svsv2 branch 2 times, most recently from f559e3d to 8ea5442 Compare March 8, 2024 20:39
@Pesa
Copy link
Member

Pesa commented Apr 25, 2024

We should probably tag a "formal" release (0.1.0 or whatever) before merging these changes btw.

@yoursunny
Copy link
Member

SVS v2 spec is merged.
Please rebase and merge this patch, so that we can close the chapter of SVSv1.

.clang-format Outdated Show resolved Hide resolved
.clang-format Show resolved Hide resolved
@pulsejet pulsejet marked this pull request as ready for review January 6, 2025 03:32
@pulsejet
Copy link
Collaborator Author

pulsejet commented Jan 6, 2025

Tested interop with the go implementation (much better than this)

@pulsejet pulsejet merged commit 7fa0af0 into master Jan 6, 2025
48 of 49 checks passed
@pulsejet pulsejet deleted the svsv2 branch January 6, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants