Fix signing of createrawtransaction name_update's #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet. Can you give a link to the first historic txid? |
|
Of course: 4d3571a0945edfa311f9a0dbb5d1e2d99b3d920f14870c9b7e4346eb01baa5ad |
Remove an unused optional argument to the SignSignature functions to simplify them.
Simplify the two SignSignature functions by making one call the other instead of duplicating the code.
Make a passed-by-ref argument that is never changed const to make this explicit.
Unify the signing of name and non-name inputs in the code. This also makes signrawtransaction work for name-operation transactions.
If createrawtransaction is called with a name operation, correctly set its nVersion as a namecoin tx.
changelog.md: atomic tx via rpc
phelixbtc
added a commit
that referenced
this pull request
May 18, 2014
Enable atomic name trades via RPC
|
Nice name btw ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix signrawtransaction to correctly handle transactions from createrawtransactions. With this, it is now fully possible to do atomic name trades via RPC commands. I've tried it out already with two wallets of mine.