Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port from namecoin-qt #109

Merged
merged 1 commit into from
Jun 16, 2014
Merged

Conversation

phelixbtc
Copy link
Contributor

RemoveFromMemoryPool - fixed handling of pending names when reorganizing the block chain
2ecd6df

RemoveFromMemoryPool - fixed handling of pending names when reorganizing the block chain
2ecd6df
@domob1812
Copy link
Contributor

ACK. I personally prefer lines to be at most 80 characters, though. (Just for the record.)

domob1812 added a commit that referenced this pull request Jun 16, 2014
@domob1812 domob1812 merged commit 49e3f27 into namecoin:namecoinq Jun 16, 2014
@phelixbtc
Copy link
Contributor Author

Unfortunately there is no info on line width in the Bitcoin coding style https://github.com/bitcoin/bitcoin/blob/master/doc/coding.md
With modern wide screens I stick below 100-110... Taking a quick glance there are plenty of lines of over 160 characters in Bitcoin. Uff. :)

@domob1812
Copy link
Contributor

It's definitely not a big problem. And as you observe, there are plenty of longer lines. I just try to shorten them wherever it seems appropriate. I started programming in GNU/Linux on a console screen, and have been working on multiple GNU projects. I got used to trying to shorten lines, so I try to keep them below 80 characters. But as there's no clear style outlined anywhere, I think just do as it looks best for you.

@phelixnmc phelixnmc deleted the RemoveFromMemoryPool branch June 23, 2014 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants