Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support go mod #142

Closed
wants to merge 1 commit into from
Closed

feat: support go mod #142

wants to merge 1 commit into from

Conversation

karllynnn
Copy link
Contributor

我把go mod相关的东西加进去了。github并不能提交合并tag,如果想要正常使用go mod,必须把tag改成v1.2.0这种格式,而且最好对以往的旧tag再用git tag v1.0.0 1.0.0这种格式加上符合语义化版本的tag.

@name5566
Copy link
Owner

对于不使用 git 的用户(例如使用 svn),你这个代码有问题不?

@karllynnn
Copy link
Contributor Author

go.mod文件只是列出了项目的依赖,实际上用户仍然可以用go get拉取仓库到GOPATH下,和以前一样使用。go mod只是给予了用户更好的版本控制能力,比如他可以直接在自己的项目里面指定leaf使用v1.1.3版。用户如果只是在自己的项目里面用svn,那他仍然可以使用go mod拉取github上公开的仓库。

不过,如果用户自己写了私有库,放在svn里,那么他可能无法使用go.mod获取该私有库(需要官方支持)。

@karllynnn
Copy link
Contributor Author

另外,麻烦你自己review一下go.mod里面的依赖版本,我这里是用go mod tidy自动生成的。

@name5566
Copy link
Owner

可以把这个提交到 experiment 分支

@name5566 name5566 closed this Dec 28, 2018
@karllynnn karllynnn mentioned this pull request Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants