Skip to content

feat: add readSheetOrThrow methods to ReaderConfig#33

Merged
nambach merged 1 commit intonambach:masterfrom
JustAnotherID:master
Jun 29, 2022
Merged

feat: add readSheetOrThrow methods to ReaderConfig#33
nambach merged 1 commit intonambach:masterfrom
JustAnotherID:master

Conversation

@JustAnotherID
Copy link
Contributor

To support the following situations:

List<Book> books = readerConfig.readSheetOrThrow(stream, rowErrors -> new BusinessException("Ignore error detail."))
                               .stream()
                               .filter(...)
                               .collect(toList());

List<Book> books = readerConfig.readSheetOrThrow(stream, rowErrors -> new BusinessException("Failed, " + rowErrors.size() + " errors!"))
                               .stream()
                               .filter(...)
                               .collect(toList());

Copy link
Owner

@nambach nambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm, have you tested these methods locally?

@nambach nambach changed the title feat: Add readSheetOrThrow methods to ReaderConfig feat: add readSheetOrThrow methods to ReaderConfig Jun 29, 2022
@JustAnotherID
Copy link
Contributor Author

Just want to confirm, have you tested these methods locally?

I tested it with my private files. By the way, there is no corresponding file like books.xlsx in your test code but hard code. I know it can be generated, but why not put it in test/resources?

@nambach
Copy link
Owner

nambach commented Jun 29, 2022

there is no corresponding file like books.xlsx in your test code but hard code.

Just for reference purpose. 😄

@nambach nambach merged commit 35393d4 into nambach:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants