Remove speculative context #4953
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grarco
added
cli
UX
client
MASP
breaking:cli
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 51fd175. 🟢 All jobs passed!But CI Insights is watching 👀 |
grarco
force-pushed
the
grarco/delete-speculative-context
branch
from
05e0230 to
ec5d786
Compare
sug0
reviewed
Nov 6, 2025
| .subcommand(QueryEffNativeSupply::def().display_order(5)) | ||
| .subcommand(QueryStakingRewardsRate::def().display_order(5)) | ||
| // Actions | ||
| .subcommand(ShieldedSync::def().display_order(6)) |
Collaborator
There was a problem hiding this comment.
can we bring back the standalone shielded sync command?
| || fst_arg.as_ref() == "unshield" | ||
| || fst_arg.as_ref() == "ibc-transfer" | ||
| || fst_arg.as_ref() == "balance" | ||
| || fst_arg.as_ref() == "estimate-shielding-rewards" |
Collaborator
There was a problem hiding this comment.
Suggested change
| || fst_arg.as_ref() == "estimate-shielding-rewards" | |
| || fst_arg.as_ref() == "estimate-shielding-rewards" | |
| || fst_arg.as_ref() == "osmosis-swap" |
Collaborator
There was a problem hiding this comment.
pls make sure that the osmosis_xcs e2e test is still working. it's not running in CI because it takes a really long time to finish. you need gaiad, osmosisd and hermes in your $PATH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4074.
Removes the speculative shielded context and the
shielded-synccli command. The shielded-sync operations is now embedded directly in the cli commands that need it:Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo