Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 9, 2025

Describe your changes

Querying the conversion state becomes more difficult as nodes progress to higher and higher epochs. For instance, on a mainnet clone running on accelerated epochs, client queries for conversions always timeout (even after modifying timeout_broadcast_tx_commit) when the node goes beyond a certain MASP epoch. This happens because the conversion state grows linearly with the MASP epoch counter. This PR attempts to address this problem by making the conversions RPC endpoint require that clients specify the MASP epoch they want conversions from. This implies two things: first the size of the response from the conversions RPC endpoint should now be constant (equal to the number of tokens in the shielded rewards program), and second a client requiring all conversions now has to do a separate query for each MASP epoch.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4776 done by [Mergify](https://mergify.com).

murisi and others added 4 commits October 9, 2025 09:08
Copy link
Contributor Author

mergify bot commented Oct 9, 2025

🧪 CI Insights

Here's what we observed from your CI run for 9332a42.

🟢 All jobs passed!

But CI Insights is watching 👀

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 9, 2025
@mergify mergify bot added the queued label Oct 9, 2025
mergify bot added a commit that referenced this pull request Oct 9, 2025
@mergify mergify bot merged commit 78f46c1 into maint-libs-0.251 Oct 9, 2025
15 of 16 checks passed
@mergify mergify bot deleted the mergify/bp/maint-libs-0.251/pr-4776 branch October 9, 2025 09:15
@mergify mergify bot removed the queued label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants