Skip to content

merge queue: embarking main (58a926b), #4816, #4878 and #4785 together #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 75 commits into from
Closed

merge queue: embarking main (58a926b), #4816, #4878 and #4785 together #4885

wants to merge 75 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 1, 2025 •
edited
Loading

✨ Pull request #4878 which was ahead in the queue has been dequeued (for the following reason: checks failed). The pull request #4785 has been re-embarked. ✨

Branch main (58a926b), #4816, #4878 and #4785 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #4785.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
    • check-success = test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-integration
    • check-skipped = test-integration
    • check-success = test-integration
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e-with-device-automation
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
  • any of [🛡 GitHub branch protection]:
    • check-success = check-benchmarks
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success = check-packages
    • check-neutral = check-packages
    • check-skipped = check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success = build-binaries
    • check-neutral = build-binaries
    • check-skipped = build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success = lints
    • check-neutral = lints
    • check-skipped = lints
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-docs
    • check-neutral = rust-docs
    • check-skipped = rust-docs
  • any of [🛡 GitHub branch protection]:
    • check-success = test-wasm
    • check-neutral = test-wasm
    • check-skipped = test-wasm
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (0)
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (1)
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (3)
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (4)
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-unit
    • check-neutral = test-unit
    • check-skipped = test-unit
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

Required conditions to stay in the queue:

  • #approved-reviews-by >= 1
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • base = main
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e-with-device-automation
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
  • any of [🛡 GitHub branch protection]:
    • check-success = check-benchmarks
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success = check-packages
    • check-neutral = check-packages
    • check-skipped = check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success = build-binaries
    • check-neutral = build-binaries
    • check-skipped = build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success = lints
    • check-neutral = lints
    • check-skipped = lints
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-docs
    • check-neutral = rust-docs
    • check-skipped = rust-docs
  • any of [🛡 GitHub branch protection]:
    • check-success = test-wasm
    • check-neutral = test-wasm
    • check-skipped = test-wasm
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (0)
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (1)
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (2)
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (3)
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (4)
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-integration
    • check-neutral = test-integration
    • check-skipped = test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success = test-unit
    • check-neutral = test-unit
    • check-skipped = test-unit
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections
---
checking_base_sha: 38682024bcafa2ecb772e511edd8fd6f75e494cf
previous_failed_batches: []
pull_requests:
  - number: 4785
...

sug0 added 30 commits September 29, 2025 10:45
@sug0
Add bridge tree dep
adcd35a
@sug0
Wrap bridge tree types
45a2467
@sug0
Build MASP witnesses locally
f7ef28f
@sug0
Derive default on shielded wallet
a3f44a9
@sug0
Build merkle proofs with bridge tree method
97a9470
@sug0
Fix successful trial decryption check
f09ccaa
@sug0
Migrate to leanbridgetree crate
46677f2
@sug0
Fix block index not being properly used
0bdd902
@sug0
Defer saving shielded spends until after we update wits
5adae71
@sug0
Improve remove mark err msg
71aeac4
@sug0
Remove unnecessary async qualifier
e704430
@sug0
Drop unused vk_map field in shielded wallet
7c7c745
@sug0
Use domain type for note positions
b69a0ae
@sug0
Save space by only storing non-empty memos
1c50609
@sug0
Remove unnecessary data from shielded wallet
8348a34
@sug0
Reorder spent notes field
3d7520f
@sug0
Migrate witness maps to bridge trees
6215166
@sug0
Remove shielded sync start height
b7a060b
@sug0
Optimize data storage of vk heights
eefd0e5
@sug0
Rework note map representation in shielded wallet
8ce76f7
@sug0
Remove unused note index cache field
dccdfab
@sug0
Compute min and max sync heights
9f1083a
@sug0
Fetch all notes necessary to update cmt tree even with birthdays
d99fa4c
@sug0
Remove space from err msg
c7fd441
@sug0
Avoid panicking on non-found note pos
d7804da
@sug0
Rework masp client capabilities
4002a26
@sug0
Hint to MASP client block range to fetch
cad6899
@sug0
Import konst to apps_lib
e332afc
@sug0
Add user agent to masp indexer http client
4af010c
@sug0
Fix bridge tree migrations from wit map
ff59de5
grarco and others added 27 commits September 30, 2025 10:03
@grarco
Slight improvement to build_batch
167a642
@grarco
Refactors signing of custom transactions
597df8c
@grarco
Fixes the accounting of the number of signatures
c6b8334
@grarco
Adds a wrapper check before tx submission
b629788
@grarco
Fixes broken tests
a0f462f
@grarco
Refactors custom tx builder
20991d2
@grarco
Refactors inner tx signers' extraction
c096ccb
@grarco
Removes redundant default signer
7106c1f
@grarco
Simplifies the interface of signing data functions
f19da12
@grarco
Fixes warning message in client and removes unnecessary owner for rev…
2060a0a 
…eal_pk txs
@grarco
Fixes comment typo
9e76505
@grarco
Refactors extraction of signing data into a separate function
cde13a2
@grarco
Removes unnecessary gas-payer from integration test
031c177
@grarco
Avoids generating empty auth section when no serialized signatures ar…
df6cb55 
…e provided
@grarco
Fixes broken masp test
8111e2d
@grarco
Reverts the logic of inner_tx_signers
eec8a90
@grarco
Upgrades build_batch to support batched transactions
0fb380f
@grarco
Changelog #4816
73c9efd
@sug0
Rewrite cap methods based on contains method
434a984
@sug0
Changelog for #4785
f97031a
@grarco
Fixes typo in changelog
603b826
@sug0
Update masp to v3.0.8
9aa7411
@sug0
Changelog for #4878
8464309
@tzemanovic
ci: add missing SDK issue category
3394fd7
@mergify
Merge of #4816
fa26022
@mergify
Merge of #4878
3868202
@mergify
Merge of #4785
e749acd
@mergify mergify bot closed this Oct 1, 2025
@mergify mergify bot deleted the mergify/merge-queue/a76997fe3b branch October 1, 2025 17:45
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Oct 1, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for e749acd.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 test-integration Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sug0 @grarco @tzemanovic