Skip conversions with no rewards #4883
Merged
+325
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backport-libs-0.251
🧪 CI InsightsHere's what we observed from your CI run for bc4f7f8. 🟢 All jobs passed!But CI Insights is watching 👀 |
|
Putting this back to draft as it needs some more work |
grarco
force-pushed
the
grarco/no-zero-reward-convs
branch
from
d2b87fb to
2813392
Compare
|
@sug0 I've fixed a bug and improved the tests, this is now ready for review |
sug0
approved these changes
Oct 8, 2025
| output: &mut I128Sum, | ||
| ) -> Result<(), eyre::Error> { | ||
| // We do not need to convert negative values | ||
| // We do not need to convert non-positive values |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
sug0
added
the
merge
This was referenced Oct 8, 2025
mergify bot
added a commit
that referenced
this pull request
Oct 9, 2025
Skip conversions with no rewards (backport #4883)
mergify bot
added a commit
that referenced
this pull request
Oct 9, 2025
…pr-4883 Skip conversions with no rewards (backport #4883)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4789.
Modifies
apply_conversionto skip conversions that don't carry any rewards (i.e. conversions that only update the epoch of the asset).Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo