Skip to content

Fix timeout refund on an unlimited channel #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 22, 2025
Merged

Fix timeout refund on an unlimited channel #4821

merged 4 commits into from
Sep 22, 2025

Conversation

yito88
Copy link
Collaborator

@yito88 yito88 commented Sep 17, 2025 •
edited
Loading

Describe your changes

closes #4822

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Sep 17, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 17, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 6c94a63.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 test-e2e (3) Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 2 View View

@github-actions github-actions bot added the breaking:api public API breaking change label Sep 17, 2025
@yito88 yito88 requested review from grarco and sug0 September 17, 2025 19:14
@brentstone brentstone added this to the Next Release milestone Sep 18, 2025
sug0
sug0 reviewed Sep 22, 2025
View reviewed changes
@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 22, 2025
mergify bot added a commit that referenced this pull request Sep 22, 2025
@mergify
Merge of #4821
e700c24
@mergify mergify bot mentioned this pull request Sep 22, 2025
Closed
mergify bot added a commit that referenced this pull request Sep 22, 2025
@mergify
Merge of #4821
b4c8a0b
@mergify mergify bot mentioned this pull request Sep 22, 2025
Closed
@mergify mergify bot merged commit 2ce4de9 into main Sep 22, 2025
62 of 64 checks passed
@mergify mergify bot deleted the yuji/fix-timeout-unlimited branch September 22, 2025 16:36
@mergify mergify bot mentioned this pull request Sep 22, 2025
Closed
3 tasks
@tzemanovic tzemanovic added the backport-201.0 Backport to app 201.0 maintenance branch label Sep 24, 2025
@mergify mergify bot mentioned this pull request Sep 24, 2025
Merged
3 tasks
mergify bot added a commit that referenced this pull request Sep 24, 2025
@mergify
Merge pull request #4837 from namada-net/mergify/bp/maint-201.0/pr-4821
990a83f 
Fix timeout refund on an unlimited channel (backport #4821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sug0 sug0 sug0 approved these changes

@grarco grarco grarco approved these changes

Assignees

No one assigned

Labels

backport-201.0 Backport to app 201.0 maintenance branch backport-libs-0.251 Backport libraries to 0.251 maintenance branch breaking:api public API breaking change merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

Refund on an unlimited channel was rejected due to the rate limit

5 participants

@yito88 @sug0 @grarco @tzemanovic @brentstone