Skip to content

Conversation

batconjurer
Copy link
Collaborator

@batconjurer batconjurer commented Sep 10, 2025

Describe your changes

The masp now uses the bellperson backend to synthesize circuits and build zk proofs. Benchmarking this indicates substantial speed ups in proving time.

@github-actions github-actions bot added the breaking:api public API breaking change label Sep 10, 2025
@tzemanovic tzemanovic removed the breaking:api public API breaking change label Sep 10, 2025
@github-actions github-actions bot added breaking:api public API breaking change backport-libs-0.251 Backport libraries to 0.251 maintenance branch labels Sep 10, 2025
@brentstone brentstone added this to the Next Release milestone Sep 18, 2025
Copy link
Contributor

mergify bot commented Sep 18, 2025

🧪 CI Insights

Here's what we observed from your CI run for 2f1aa68.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 test-e2e (2) Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
test-e2e (3) Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
test-integration Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
test-unit Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@sug0 sug0 added the MASP label Sep 22, 2025
@sug0
Copy link
Collaborator

sug0 commented Sep 22, 2025

since this PR changes the backend globally (i.e. not just client-side, but also validator-side), it would be nice to test it by validating proofs produced with bellman, e.g. by running a fullnode with the new bellperson backend against some network that had committed masp txs with proofs still produced with bellman

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 22, 2025
mergify bot added a commit that referenced this pull request Sep 22, 2025
mergify bot added a commit that referenced this pull request Sep 22, 2025
Copy link
Contributor

mergify bot commented Sep 22, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #4827.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Copy link
Contributor

mergify bot commented Sep 22, 2025

Hey @batconjurer, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@batconjurer
Copy link
Collaborator Author

since this PR changes the backend globally (i.e. not just client-side, but also validator-side), it would be nice to test it by validating proofs produced with bellman, e.g. by running a fullnode with the new bellperson backend against some network that had committed masp txs with proofs still produced with bellman

So I checked locally that shielding, shielded transfer, and unshielding all works when a devnet uses bellperson but the client is built from main

@brentstone
Copy link
Collaborator

@tzemanovic @batconjurer I think it might be worth cutting a path release v201.0.6 that also just has this alone on top of v201.0.5. Thoughts?

@tzemanovic tzemanovic added the backport-201.0 Backport to app 201.0 maintenance branch label Sep 24, 2025
@Fraccaman
Copy link
Collaborator

since this PR changes CI with a new image version I think we could first upgrade CI, rebase this one and then merge it. Im going to open a PR shortly.

@Fraccaman Fraccaman removed the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 24, 2025
@Fraccaman Fraccaman mentioned this pull request Sep 24, 2025
3 tasks
@sug0 sug0 mentioned this pull request Sep 26, 2025
3 tasks
@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 26, 2025
@mergify mergify bot added the queued label Sep 26, 2025
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

mergify bot added a commit that referenced this pull request Sep 26, 2025
@mergify mergify bot merged commit e56bba9 into main Sep 26, 2025
27 checks passed
@mergify mergify bot deleted the bat/bellperson branch September 26, 2025 13:31
@mergify mergify bot removed the queued label Sep 26, 2025
mergify bot added a commit that referenced this pull request Sep 26, 2025
…pr-4817

Change MASP zk backend to bellperson (backport #4817)
mergify bot added a commit that referenced this pull request Sep 26, 2025
Change MASP zk backend to bellperson (backport #4817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-201.0 Backport to app 201.0 maintenance branch backport-libs-0.251 Backport libraries to 0.251 maintenance branch breaking:api public API breaking change MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants