-
Notifications
You must be signed in to change notification settings - Fork 1k
Change MASP zk backend to bellperson #4817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🧪 CI InsightsHere's what we observed from your CI run for 2f1aa68. ✅ Passed Jobs With Interesting Signals
|
since this PR changes the backend globally (i.e. not just client-side, but also validator-side), it would be nice to test it by validating proofs produced with |
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4827. You may have to fix your CI before adding the pull request to the queue again. |
Hey @batconjurer, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
So I checked locally that shielding, shielded transfer, and unshielding all works when a devnet uses bellperson but the client is built from main |
@tzemanovic @batconjurer I think it might be worth cutting a path release v201.0.6 that also just has this alone on top of v201.0.5. Thoughts? |
since this PR changes CI with a new image version I think we could first upgrade CI, rebase this one and then merge it. Im going to open a PR shortly. |
00263a5
to
2f1aa68
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…pr-4817 Change MASP zk backend to bellperson (backport #4817)
Change MASP zk backend to bellperson (backport #4817)
Describe your changes
The masp now uses the bellperson backend to synthesize circuits and build zk proofs. Benchmarking this indicates substantial speed ups in proving time.