-
Notifications
You must be signed in to change notification settings - Fork 1k
Improve speculative shielded ctx #4019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
batconjurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from sug0's requested changes, this looks fine
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4019 +/- ##
==========================================
- Coverage 73.92% 73.91% -0.01%
==========================================
Files 341 341
Lines 106510 106496 -14
==========================================
- Hits 78740 78720 -20
- Misses 27770 27776 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
sug0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of nits but otherwise lgtm
Improve speculative shielded ctx (backport #4019)
Describe your changes
Closes #3457.
Closes #2593.
Moved the transition to the
SpeculativeContextfrom the SDK to the client to have access to the (possible) tx result. The transition is now performed when:The transition is not performed when:
Added an integration test to verify the behavior of the client when in a speculative context.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo