.NET SDK release/dnup branch build uses dotnetup to download core .NET runtimes#8
Closed
nagilson wants to merge 4 commits intonagilson-dnup-install-runtimes-implfrom
Closed
Conversation
InitializeDotnetCli installs the .NET 10 SDK EnsureDotnetupBuilt checks if dotnetup.exe exists, builds it if not InstallDotNetSharedFramework uses dotnetup to install runtimes 6.0, 7.0, 8.0, 9.0 - I considered containing the dotnetup exe itself or acquiring it but that would require sign checks to be secure.
…mpl' into nagilson-sdk-uses-dnup-for-core-runtimes
nagilson
commented
Jan 27, 2026
We also get rid of the deletion of pdbs - it's an unncessary step. Also, we don't fall back to the install script - we want to fail if dotnetup fails so we know it's failing. It should never fail. It if fails we want to find out why and fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of dotnet#52649, we want to be a first party dogfooder to QA our product, evaluate its functionality as a user, and gain confidence in its ability to be publicly consumed elsewhere. This is not going to apply to
mainor any official branch currently releasing because we still need approval for that pending other work items.We will eventually install nightly SDK and Runtimes with this as well, but this is a good stop gap for now. To make that work we need to download a dotnetup executable, because we can't build dotnetup without the SDK. Since we don't have that acquisition experience of dotnetup itself done, and it doesn't yet install preview SDKs, I think this is good for now.
Note this will fail quite often until dotnet#52696 is merged which fixes a bug in dotnetup.