支持修改context-path #290
Merged
支持修改context-path #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hujun-w-2
reviewed
Jun 23, 2023
| @@ -105,7 +106,7 @@ private Properties buildSubNacosProperties(Properties globalProperties, | |||
| config.getServerAddr(), config.getNamespace(), config.getEndpoint(), | |||
| config.getSecretKey(), config.getAccessKey(), config.getRamRoleName(), | |||
| config.getConfigLongPollTimeout(), config.getConfigRetryTime(), | |||
| config.getMaxRetry(), config.isEnableRemoteSyncConfig(), | |||
| config.getMaxRetry(),null, config.isEnableRemoteSyncConfig(), | |||
There was a problem hiding this comment.
这里是扩展配置的构建，为null时会默认继承主配置里面的配置项，如果使用默认配置的话会和主配置不一致。当主配置项没有配置context-path时，主配置的context-path就是默认值，扩展配置会同步继承默认配置，所以这个地方是null就可以了
There was a problem hiding this comment.
spring-cloud-alibaba 中context-path配置是可以修改的，希望修改可以被接受
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 #288 问题，经过测试，请合并