-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUEhttps://github.com/alibaba/nacos/issues/6999]Managed log framework #228
[ISSUEhttps://github.com/alibaba/nacos/issues/6999]Managed log framework #228
Conversation
nacos托管日志框架方案.pdf |
测试前提: |
@realJackSun @KomachiSion @chuntaojun 能否帮忙review一下 |
Looks good. |
|
||
} | ||
|
||
private void writeLogFile(String content, String dataId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nacos client will cache config in cache dir, why cache agqin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nacos client will cache config in cache dir, why cache agqin?
The purpose of writing the configuration content into the file here is to facilitate the log framework to read from the directory, because the snapshot file path of the Nacos client is not exposed. If the dead path written on the springboot side points to the Nacos client, problems will occur later when the Nacos client is changed.
} | ||
} | ||
|
||
public Properties buildGlobalNacosProperties() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These properties whether has built in other Configuration class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll optimize it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modification has been completed
for #alibaba/nacos#6999