参数：远程配置和本地 application.properties 的优先级 #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuntaojun
reviewed
Feb 27, 2020
| mutablePropertySources.addLast(propertySource); | ||
|
|
||
| if (nacosConfigProperties.isRemoteFirst()) { | ||
| for (ListIterator<NacosPropertySource> itr = sources.listIterator(sources.size()); itr.hasPrevious();) { |
There was a problem hiding this comment.
远程配置应当是和Application.properties同样地位的，但是这里直接暴力的addFirst我觉得不太好，希望还是保留spring原有的对于配置优先级的概念，不要暴力的addFirst，而是添加到某个配置之前，某个配置之后这样做
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
通过配置 nacos.config.remote-first=true, 使远程配置优先级高于本地 application.properties