It should use onRequestFail:false when handler reply ConnectResetRequeset #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stFail true when reply connectResetReq
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 32.69% 32.93% +0.24%
==========================================
Files 45 45
Lines 3294 3294
==========================================
+ Hits 1077 1085 +8
+ Misses 2136 2126 -10
- Partials 81 83 +2 ☔ View full report in Codecov by Sentry. |
binbin0325
reviewed
Jan 23, 2024
| @@ -30,7 +30,7 @@ jobs: | |||
| run: | | |||
| diff -u <(echo -n) <(gofmt -d -s .) | |||
| diff -u <(echo -n) <(goimports -d .) | |||
| go test -v -race ./... -coverprofile=coverage.txt -covermode=atomic | |||
| go test -gcflags "all=-N -l" -v -race ./... -coverprofile=coverage.txt -covermode=atomic | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.