Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[version compatibility] fix up when response.ResultCode is 200 but response.Success is false #699

Merged

Conversation

robynron
Copy link
Contributor

@robynron robynron commented Dec 15, 2023

fix #698

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8677a56) 29.81% compared to head (e2b75d5) 31.46%.

❗ Current head e2b75d5 differs from pull request most recent head 7209316. Consider uploading reports for the commit 7209316 to get more accurate results

Files Patch % Lines
common/remote/rpc/rpc_response/utils.go 84.61% 1 Missing and 1 partial ⚠️
common/remote/rpc/grpc_connection.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
+ Coverage   29.81%   31.46%   +1.64%     
==========================================
  Files          41       45       +4     
  Lines        3153     3261     +108     
==========================================
+ Hits          940     1026      +86     
- Misses       2140     2160      +20     
- Partials       73       75       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robynron
Copy link
Contributor Author

image

@KomachiSion KomachiSion merged commit 7178ed3 into nacos-group:master Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[version compatibility] success field of nacos server's response is empty
3 participants