-
Notifications
You must be signed in to change notification settings - Fork 2
update schemas to reflect what asset_tracker_v2 is actually sending #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1
Are you sure you want to change the base?
update schemas to reflect what asset_tracker_v2 is actually sending #51
Conversation
3bcb036
to
77b5257
Compare
@@ -54,9 +54,9 @@ | |||
"type": "integer" | |||
}, | |||
"mccmnc": { | |||
"type": "string", | |||
"type": "integer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been a string for a long time.
ATv2 has its own implementation, which is a number.
i have no preference, other than that all code in NCS is aligned.
@@ -127,12 +128,13 @@ | |||
}, | |||
"appName": { | |||
"type": "string" | |||
}, | |||
"iccid": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ICCID, along with IMSI and UICC mode, has been reported in the "simInfo" section for a long time.
again, no preference, but all NCS code should be aligned.
00917f7
to
e32d679
Compare
@@ -171,9 +171,9 @@ | |||
"type": "integer" | |||
}, | |||
"mccmnc": { | |||
"type": "string", | |||
"type": "number", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the modem_info library provides a string for this value.
the nrf_cloud library reports this value as a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current asset_tracker_v2 sends number:
"roam": {
"v": {
"band": 12,
"nw": "LTE-M",
"rsrp": -119,
"area": 34635,
"mccmnc": 310410,
"cell": 141255696,
"ip": "10.165.115.123",
"eest": 7
},
"ts": 1681909040890
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change for fw apps using modem_info library or nrf_cloud library to update the shadow.
@coderbyheart. The NCS change notes says that you provide BATTERY and not VOLTAGE appid. I do not see that change here? Or should there be new PR Also, the BATTERY level seems to be from PMIC. Does all our Thingys and DKs contain the needed PMIC? |
I haven't added this, yet.
I don't know. |
b3598a5
to
37ac0f3
Compare
Added. |
Removing reference in shadow as well. See nrfconnect/sdk-nrf#10927
17e75c2
to
5ba9b31
Compare
This aligns the schemas to match the data sent by
asset_tracker_v2
.Question remains where this mismatch should be fixed, it could also be fixed on the firmware side.