Bring XmlParsing in line with hapi - also unblocks #308#398
Merged
Conversation
milkshakeuk
force-pushed
the
XmlParserInprovements
branch
from
December 23, 2022 21:08
8a65375 to
6ecb583
Compare
milkshakeuk
force-pushed
the
XmlParserInprovements
branch
3 times, most recently
from
December 23, 2022 22:22
1162c13 to
97cdbff
Compare
milkshakeuk
force-pushed
the
XmlParserInprovements
branch
from
December 30, 2022 16:14
97cdbff to
c47095c
Compare
Member
Author
|
@AMCN41R @duaneedwards @PhantomGrazzler hope you gad a good Christmas and I hope you have a great new year! 🎇🎆 |
milkshakeuk
force-pushed
the
XmlParserInprovements
branch
3 times, most recently
from
December 31, 2022 12:51
a54fa37 to
377e077
Compare
PhantomGrazzler
approved these changes
Jan 2, 2023
milkshakeuk
force-pushed
the
XmlParserInprovements
branch
from
January 5, 2023 10:48
377e077 to
3f56035
Compare
PhantomGrazzler
approved these changes
Jan 5, 2023
Member
Author
|
@AMCN41R @duaneedwards have you guys had chance to have a quick look? |
AMCN41R
reviewed
Jan 5, 2023
AMCN41R
left a comment
AMCN41R
left a comment
Collaborator
There was a problem hiding this comment.
Couple of comments about the addition of .? potentially changing behaviour in places, otherwise looks good 👍
* Port hapi version of XMLParser and DefaultXMLParser - nHapi versions of these were years behind hapi. * Keep old implementations as LegacyXMLParser and LegacyDefaultXMLParser for people or depend on old imperfect behaviour * Add Unit tests for changes * Fix some code styling warnings * Improve XML Documentation * Update some Nuget packages * Unblocks #308 * Closes some Dependabot pull requests
milkshakeuk
force-pushed
the
XmlParserInprovements
branch
from
January 5, 2023 21:21
3f56035 to
6926c42
Compare
AMCN41R
approved these changes
Jan 6, 2023
AMCN41R
approved these changes
Jan 6, 2023
AMCN41R
self-requested a review
January 6, 2023 10:18
AMCN41R
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hapiversion ofXMLParserandDefaultXMLParser-nHapiversions of these were years behindhapi.LegacyXMLParserandLegacyDefaultXMLParserfor people or depend on old imperfect behaviour