Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Setup pnpm catalog to centralize depedency versions (no-changelog) #9974

Merged
merged 11 commits into from
Jul 30, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jul 8, 2024

Summary

pnpm 9.5 added a new feature called catalog that helps organize dependency versions in a centralized location, to help maintain consistent versions of dependencies and to make upgrading duplicated dependencies easier.

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 8, 2024
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Just one Q about how to categorize the catalogs

Comment on lines +8 to +9
'@types/basic-auth': ^1.1.3
'@types/express': ^4.17.21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are used only in the backend packages. Should we have a separate backend catalog like we have one for frontend?

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 30, 2024



Test summary

389 0 0 0Flakiness 0


Run details

Project n8n
Status Passed
Commit f3a5a1f
Started Jul 30, 2024 7:39 AM
Ended Jul 30, 2024 7:44 AM
Duration 04:46 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@netroy netroy merged commit a2d0884 into master Jul 30, 2024
27 checks passed
@netroy netroy deleted the pnpm-catalog branch July 30, 2024 11:27
@janober
Copy link
Member

janober commented Jul 31, 2024

Got released with n8n@1.53.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants