feat(MongoDB Node): Add projection to query options on Find #9972
Conversation
|
|
|
AFAIK there is no tests at all on this node, but if you help me to help you, I can try to write some. |
n8n-assistant
bot
added
community
mickaelandrieu
force-pushed
the
mongodb/projection-support
branch
from
304262d
to
431a2f5
Compare
|
Thanks for the review, I've improved my contribution |
mickaelandrieu
changed the title
mickaelandrieu
changed the title
Joffcom
changed the title
|
Hi, just a friendly reminder (also I really need this feature to be added in the core 🙏) |
|
Hey @mickaelandrieu, I have fixed the remaining lint issues so we can get this merged. Thanks for the work you have done on this. |
|
Thanks ! Always happy to help 👍 Can you help me to update the docs ? I don't know where it's located (same repository ?) |
|
Hey @mickaelandrieu, The docs are under n8n-io/n8n-docs but I don't think this change needs a docs update so we are all good. |
|
Got released with |
* master: refactor(core): Centralize scaling mode (no-changelog) (#9835) fix(editor): Remove body padding from storybook previews (no-changelog) (#10317) feat(MySQL Node): Return decimal types as numbers (#10313) 🚀 Release 1.54.0 (#10315) feat(Elasticsearch Node): Add bulk operations for Elasticsearch (#9940) feat(Stripe Trigger Node): Add Stripe webhook descriptions based on the workflow ID and name (#9956) feat(MongoDB Node): Add projection to query options on Find (#9972) fix(Invoice Ninja Node): Fix payment types (#10196) feat(HTTP Request Tool Node): Use DynamicStructuredTool with models supporting it (no-changelog) (#10246) feat: Return scopes on executions (no-changelog) (#10310) feat(Webflow Node): Update to use the v2 API (#9996) feat(Lemlist Trigger Node): Update Trigger events (#10311) feat(Calendly Trigger Node): Update event names (no-changelog) (#10129) refactor(core): Reorganize webhook related components under src/webhooks (no-changelog) (#10296) docs: Fix links to license files in readme (no-changelog) (#10257) fix(editor): Update design system Avatar component to show initials also when only firstName or lastName is given (#10308) fix(editor): Update tags filter/editor to not show non existing tag as a selectable option (#10297) fix(editor): Update project tabs test (no-changelog) (#10300) fix(core): VM2 sandbox should not throw on `new Promise` (#10298) # Conflicts: # packages/design-system/src/components/N8nAvatar/Avatar.vue
| @@ -208,6 +210,10 @@ export class MongoDb implements INodeType { | |||
| query = query.sort(sort); | |||
| } | |||
|
|
|||
| if (projection && projection instanceof Document) { | |||
There was a problem hiding this comment.
Hi @Joffcom, I'm sorry but it looks like this object is never imported and came from bson module (which is not a direct dependency).
I'm wondering why calling a projection throws a "Document is not defined" error, but not all the previous calls in this file : what do I have done wrong, here ? :/
Summary
This contribution introduces the support of projections for the official MongoDB node.
The main intent is to reduce the time and ressources to retrieve documents.
Related Linear tickets, Github issues, and Community forum posts
=> #6975
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)