fix: Prevent undefined issues when restoring binary data #7419

krynble · 2023-10-12T10:23:44Z

Github issue / Community forum post (link here to close automatically):

github-actions · 2023-10-12T10:24:02Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

mutdmour · 2023-10-12T10:42:28Z

packages/cli/src/executionLifecycleHooks/restoreBinaryDataId.ts

@@ -20,7 +20,7 @@ export async function restoreBinaryDataId(run: IRun, executionId: string) {
 	const { runData } = run.data.resultData;

 	const promises = Object.keys(runData).map(async (nodeName) => {
-		const binaryDataId = runData[nodeName]?.[0]?.data?.main?.[0]?.[0]?.binary?.data.id;
+		const binaryDataId = runData[nodeName]?.[0]?.data?.main?.[0]?.[0]?.binary?.data?.id;


can we add a test here for this bug?

@krynble #7420

Thanks for the note @mutdmour - Ivan did add. Would you like to review?

codecov · 2023-10-12T10:45:43Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c77042f) 33.50% compared to head (b203665) 33.50%.
Report is 7 commits behind head on master.

❗ Current head b203665 differs from pull request most recent head e2af7ef. Consider uploading reports for the commit e2af7ef to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7419   +/-   ##
=======================================
  Coverage   33.50%   33.50%           
=======================================
  Files        3389     3389           
  Lines      207020   207020           
  Branches    22335    22339    +4     
=======================================
+ Hits        69360    69366    +6     
+ Misses     136539   136533    -6     
  Partials     1121     1121

Files	Coverage Δ
...src/executionLifecycleHooks/restoreBinaryDataId.ts	`93.33% <0.00%> (ø)`

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The first test ("itemless case") was originally added [here](https://github.com/n8n-io/n8n/pull/7305/files#diff-7bc4c6fd25a41ea39cef04208c96965f55787e1983e9df748fcd923672959f8bL24) but likely removed on accident.

cypress · 2023-10-12T14:34:28Z

Passing run #2479 ↗︎

0	251	0	0	0

Details:

🌳 help-353-endless-executions-for-cloud-user-rentslam 🖥️ browsers:node18.12.0-...
Project: n8n	Commit: `e2af7ef31a`
Status: Passed	Duration: 09:37 💡
Started: Oct 12, 2023 2:24 PM	Ended: Oct 12, 2023 2:34 PM

Review all test suite changes for PR #7419 ↗︎

github-actions · 2023-10-12T14:34:40Z

✅ All Cypress E2E specs passed

Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

## [1.11.1](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.11.1) (2023-10-13) ### Bug Fixes * **core:** Do not throw when deleting workflows with executions without binary-data ([#7411](#7411)) ([cde331d](cde331d)) * **core:** Fix ignoring crashed executions without event msgs ([#7368](#7368)) ([ca0d4d2](ca0d4d2)) * **editor:** Fix remote options fetching on every keystroke ([#7320](#7320)) ([15f891b](15f891b)) * Prevent undefined issues when restoring binary data ([#7419](#7419)) ([5da8dcb](5da8dcb)) Co-authored-by: krynble <krynble@users.noreply.github.com>

janober · 2023-10-17T16:27:38Z

Got released with n8n@1.11.1

# [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0) (2023-10-18) ### Bug Fixes * **core:** Add check that queue is defined and remove cyclic dependency ([#7404](#7404)) ([45f2ef3](45f2ef3)) * **core:** Do not throw when deleting workflows with executions without binary-data ([#7411](#7411)) ([2b6a15e](2b6a15e)) * **core:** Fix expression with paired item with multi-input node ([#7424](#7424)) ([ec14141](ec14141)) * **core:** Fix ignoring crashed executions without event msgs ([#7368](#7368)) ([2f4d91b](2f4d91b)) * **core:** Pg-promise de-initialization fix ([#7417](#7417)) ([7703904](7703904)) * **core:** Prevent false stalled jobs in queue mode from displaying as errored ([#7435](#7435)) ([e01b9e5](e01b9e5)) * **core:** Prevent undefined issues when restoring binary data ([#7419](#7419)) ([46977a2](46977a2)) * **editor:** Fix remote options fetching on every keystroke ([#7320](#7320)) ([367255a](367255a)) * **editor:** Open only one tab with plans page ([#7377](#7377)) ([c599006](c599006)) * **Google Sheets Node:** Update by row_number, restored 'Handling Extra Data Option', updated Cell Format default ([#7357](#7357)) ([d8531a5](d8531a5)) * **Ldap Node:** Fix issue with connections not closing correctly ([#7432](#7432)) ([c3f0be8](c3f0be8)) * **Set Node:** Null should not throw an error ([#7416](#7416)) ([e9b6ab0](e9b6ab0)) * **TheHive 5 Node:** Observable encoding in alert > create fix ([#7450](#7450)) ([a2d2e3d](a2d2e3d)) ### Features * **core:** Make executions pruning interval configurable ([#7439](#7439)) ([40707fa](40707fa)) * **Google Calendar Trigger Node:** Add support for cancelled events ([#7436](#7436)) ([9d241a0](9d241a0)) * **HubSpot Trigger Node:** Add support for ticket related events ([#7156](#7156)) ([57c6093](57c6093)) * **n8n Form Trigger Node:** New node ([#7130](#7130)) ([3ddc176](3ddc176)) * **Spreadsheet File Node:** Improve CSV parsing ([#7448](#7448)) ([79f23fb](79f23fb)) Co-authored-by: netroy <netroy@users.noreply.github.com>

Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

# [1.12.0](https://github.com/n8n-io/n8n/compare/n8n@1.11.0...n8n@1.12.0) (2023-10-18) ### Bug Fixes * **core:** Add check that queue is defined and remove cyclic dependency ([#7404](#7404)) ([45f2ef3](45f2ef3)) * **core:** Do not throw when deleting workflows with executions without binary-data ([#7411](#7411)) ([2b6a15e](2b6a15e)) * **core:** Fix expression with paired item with multi-input node ([#7424](#7424)) ([ec14141](ec14141)) * **core:** Fix ignoring crashed executions without event msgs ([#7368](#7368)) ([2f4d91b](2f4d91b)) * **core:** Pg-promise de-initialization fix ([#7417](#7417)) ([7703904](7703904)) * **core:** Prevent false stalled jobs in queue mode from displaying as errored ([#7435](#7435)) ([e01b9e5](e01b9e5)) * **core:** Prevent undefined issues when restoring binary data ([#7419](#7419)) ([46977a2](46977a2)) * **editor:** Fix remote options fetching on every keystroke ([#7320](#7320)) ([367255a](367255a)) * **editor:** Open only one tab with plans page ([#7377](#7377)) ([c599006](c599006)) * **Google Sheets Node:** Update by row_number, restored 'Handling Extra Data Option', updated Cell Format default ([#7357](#7357)) ([d8531a5](d8531a5)) * **Ldap Node:** Fix issue with connections not closing correctly ([#7432](#7432)) ([c3f0be8](c3f0be8)) * **Set Node:** Null should not throw an error ([#7416](#7416)) ([e9b6ab0](e9b6ab0)) * **TheHive 5 Node:** Observable encoding in alert > create fix ([#7450](#7450)) ([a2d2e3d](a2d2e3d)) ### Features * **core:** Make executions pruning interval configurable ([#7439](#7439)) ([40707fa](40707fa)) * **Google Calendar Trigger Node:** Add support for cancelled events ([#7436](#7436)) ([9d241a0](9d241a0)) * **HubSpot Trigger Node:** Add support for ticket related events ([#7156](#7156)) ([57c6093](57c6093)) * **n8n Form Trigger Node:** New node ([#7130](#7130)) ([3ddc176](3ddc176)) * **Spreadsheet File Node:** Improve CSV parsing ([#7448](#7448)) ([79f23fb](79f23fb)) Co-authored-by: netroy <netroy@users.noreply.github.com>

fix: Prevent undefined issues when restoring binary data

b203665

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Oct 12, 2023

mutdmour reviewed Oct 12, 2023

View reviewed changes

test(core): Add tests for endless execution issue (#7420)

e2af7ef

The first test ("itemless case") was originally added [here](https://github.com/n8n-io/n8n/pull/7305/files#diff-7bc4c6fd25a41ea39cef04208c96965f55787e1983e9df748fcd923672959f8bL24) but likely removed on accident.

krynble marked this pull request as ready for review October 12, 2023 14:15

mutdmour approved these changes Oct 12, 2023

View reviewed changes

krynble merged commit 46977a2 into master Oct 12, 2023
56 checks passed

krynble deleted the help-353-endless-executions-for-cloud-user-rentslam branch October 12, 2023 14:41

krynble added a commit that referenced this pull request Oct 12, 2023

fix: Prevent undefined issues when restoring binary data (#7419)

5da8dcb

Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

github-actions bot mentioned this pull request Oct 12, 2023

🚀 Release 1.11.1 #7426

Merged

janober added the Released label Oct 17, 2023

github-actions bot mentioned this pull request Oct 18, 2023

🚀 Release 1.12.0 #7459

Merged

elsmr pushed a commit that referenced this pull request Oct 19, 2023

fix: Prevent undefined issues when restoring binary data (#7419)

e7f92ba

Github issue / Community forum post (link here to close automatically): --------- Co-authored-by: Iván Ovejero <ivov.src@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Prevent undefined issues when restoring binary data #7419

fix: Prevent undefined issues when restoring binary data #7419

krynble commented Oct 12, 2023

github-actions bot commented Oct 12, 2023

mutdmour Oct 12, 2023

ivov Oct 12, 2023

krynble Oct 12, 2023

codecov bot commented Oct 12, 2023 •

edited

Loading

cypress bot commented Oct 12, 2023

github-actions bot commented Oct 12, 2023

janober commented Oct 17, 2023

fix: Prevent undefined issues when restoring binary data #7419

fix: Prevent undefined issues when restoring binary data #7419

Conversation

krynble commented Oct 12, 2023

github-actions bot commented Oct 12, 2023

mutdmour Oct 12, 2023

Choose a reason for hiding this comment

ivov Oct 12, 2023

Choose a reason for hiding this comment

krynble Oct 12, 2023

Choose a reason for hiding this comment

codecov bot commented Oct 12, 2023 • edited Loading

Codecov Report

cypress bot commented Oct 12, 2023

Passing run #2479 ↗︎

Review all test suite changes for PR #7419 ↗︎

github-actions bot commented Oct 12, 2023

janober commented Oct 17, 2023

codecov bot commented Oct 12, 2023 •

edited

Loading