fix(core): Missing pairing info #7326

michael-radency · 2023-10-03T07:48:59Z

Github issue / Community forum post (link here to close automatically):

github-actions · 2023-10-03T07:49:18Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

codecov · 2023-10-03T08:16:55Z

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (3e7a4d3) 33.48% compared to head (3a9abab) 33.48%.
Report is 16 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7326      +/-   ##
==========================================
- Coverage   33.48%   33.48%   -0.01%     
==========================================
  Files        3388     3388              
  Lines      206341   206429      +88     
  Branches    22281    22287       +6     
==========================================
+ Hits        69094    69121      +27     
- Misses     136128   136189      +61     
  Partials     1119     1119

Files	Coverage Δ
.../nodes-base/nodes/Airtable/test/v2/node/helpers.ts	`78.57% <100.00%> (+3.57%)`	⬆️
...es/nodes-base/nodes/Airtable/v1/AirtableV1.node.ts	`19.86% <100.00%> (+1.07%)`	⬆️
...odes/Airtable/v2/actions/base/getMany.operation.ts	`96.00% <100.00%> (+0.16%)`	⬆️
...des/Airtable/v2/actions/record/search.operation.ts	`82.92% <100.00%> (+0.42%)`	⬆️
...des-base/nodes/CompareDatasets/GenericFunctions.ts	`84.18% <100.00%> (ø)`
...e/BigQuery/v2/actions/database/insert.operation.ts	`55.40% <100.00%> (+0.61%)`	⬆️
...des-base/nodes/Microsoft/Excel/v2/helpers/utils.ts	`96.84% <100.00%> (+0.03%)`	⬆️
...ackages/nodes-base/nodes/MySql/v2/helpers/utils.ts	`69.94% <100.00%> (+0.35%)`	⬆️
...base/nodes/ReadBinaryFiles/ReadBinaryFiles.node.ts	`100.00% <100.00%> (ø)`
packages/nodes-base/nodes/Set/v1/SetV1.node.ts	`87.80% <ø> (ø)`
... and 36 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…check-paired-item-errors-for-operations-missing-pairing-info

maspio · 2023-10-06T11:51:47Z

packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/append.operation.ts

+		const executionData = this.helpers.constructExecutionMetaData(wrapData(setData), {
+			itemData,
+		});
+		return executionData;


These should map the matching incoming item instead of setting all input items as pairedItem.

maspio · 2023-10-06T11:53:51Z

packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/appendOrUpdate.operation.ts

+		const executionData = this.helpers.constructExecutionMetaData(wrapData(mappedValues), {
+			itemData,
+		});
+		return executionData;


Like above, these should map the matching incoming item instead of setting all input items as pairedItem.

maspio · 2023-10-06T12:12:36Z

packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/update.operation.ts

+		const executionData = this.helpers.constructExecutionMetaData(wrapData(mappedValues), {
+			itemData,
+		});
+		return executionData;


These should map the matching incoming item instead of setting all input items as pairedItem.

…check-paired-item-errors-for-operations-missing-pairing-info

cypress · 2023-10-10T15:07:00Z

2 flaky tests on run #2457 ↗︎

0	250	0	0	2

Details:

🌳 node-802-check-paired-item-errors-for-operations-missing-pairing-info 🖥️ bro...
Project: n8n	Commit: `3a9abab7a3`
Status: Passed	Duration: 09:14 💡
Started: Oct 10, 2023 2:57 PM	Ended: Oct 10, 2023 3:07 PM

2-credentials.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Credentials > should create a new credential using Add Credential button		`Output` `Screenshots` `Video`

27-two-factor-authentication.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Two-factor authentication > Should be able to login with MFA token		`Output` `Screenshots` `Video`

Review all test suite changes for PR #7326 ↗︎

github-actions · 2023-10-10T15:07:11Z

✅ All Cypress E2E specs passed

@Version

# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0) (2023-10-11) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([789e1e7](789e1e7)) * **core:** Fix error on missing paired item data ([#7399](#7399)) ([47e8953](47e8953)) * **core:** Missing pairing info ([#7326](#7326)) ([e2c3c7a](e2c3c7a)) * **core:** Prevent object deletion request on no prefix match ([#7366](#7366)) ([63e11e4](63e11e4)) * **editor:** Fix completions for `.json` on quoted node name in Code node ([#7382](#7382)) ([86e7ec7](86e7ec7)) * **editor:** Implement canvas zoom UX improvements ([#7376](#7376)) ([7e06b31](7e06b31)) * **editor:** Make workflow history button available only for dev builds ([#7392](#7392)) ([7ed466d](7ed466d)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([3fa2764](3fa2764)) * **editor:** Sanitize HTML binary-data before rendering in the UI ([#7400](#7400)) ([2b075bf](2b075bf)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([afbf0c3](afbf0c3)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([97bb703](97bb703)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([3e7a4d3](3e7a4d3)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([732b15a](732b15a)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([77643e5](77643e5)) * **Notion Node:** Handle empty values correctly for Notion selects + multi selects ([#7383](#7383)) ([fbcd1d4](fbcd1d4)) * **Set Node:** Increase search priority ([#7358](#7358)) ([e5ad1e7](e5ad1e7)) * **Webhook Node:** Backward compatible form-data parsing for non-array files ([#7385](#7385)) ([6479eb1](6479eb1)) ### Features * **core:** Add Job Summary to Worker response ([#7360](#7360)) ([b8608ce](b8608ce)) * **core:** Integrate object store as binary data manager ([#7253](#7253)) ([1a661e6](1a661e6)) * **core:** Switch binary filesystem mode to nested path structure ([#7307](#7307)) ([0847623](0847623)) * **editor:** Make PDF and Audio binary-data viewable in the UI ([#7367](#7367)) ([8187be1](8187be1)) * **editor:** Support autologin for upgrade path ([#7316](#7316)) ([1dfa052](1dfa052)) * **Execute Workflow Node:** Run once for each item mode ([#7289](#7289)) ([c8c14ca](c8c14ca)) * **Item Lists Node:** Split merge binary data ([#7297](#7297)) ([965db8f](965db8f)) * **Loop Over Items (Split in Batches) Node:** Automatically add a loop + rename ([#7228](#7228)) ([7b773cc](7b773cc)) * **Notion Node:** Fetch child blocks recursively ([#7304](#7304)) ([193181a](193181a)) Co-authored-by: netroy <netroy@users.noreply.github.com>

janober · 2023-10-11T13:57:16Z

Got released with n8n@1.11.0

* master: fix(core): Fix ignoring crashed executions without event msgs (#7368) ci: Enable ARM64 builds for beta images (no-changelog) (#7403) 🚀 Release 1.11.0 (#7402) fix(editor): Sanitize HTML binary-data before rendering in the UI (#7400) fix(core): Fix error on missing paired item data (#7399) feat(editor): Workflow history [WIP]- Create workflow history item preview component (no-changelog) (#7378) feat(Item Lists Node): Split merge binary data (#7297) fix(core): Missing pairing info (#7326) fix(Webhook Node): Backward compatible form-data parsing for non-array files (#7385)

@Version

# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0) (2023-10-11) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([789e1e7](789e1e7)) * **core:** Fix error on missing paired item data ([#7399](#7399)) ([47e8953](47e8953)) * **core:** Missing pairing info ([#7326](#7326)) ([e2c3c7a](e2c3c7a)) * **core:** Prevent object deletion request on no prefix match ([#7366](#7366)) ([63e11e4](63e11e4)) * **editor:** Fix completions for `.json` on quoted node name in Code node ([#7382](#7382)) ([86e7ec7](86e7ec7)) * **editor:** Implement canvas zoom UX improvements ([#7376](#7376)) ([7e06b31](7e06b31)) * **editor:** Make workflow history button available only for dev builds ([#7392](#7392)) ([7ed466d](7ed466d)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([3fa2764](3fa2764)) * **editor:** Sanitize HTML binary-data before rendering in the UI ([#7400](#7400)) ([2b075bf](2b075bf)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([afbf0c3](afbf0c3)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([97bb703](97bb703)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([3e7a4d3](3e7a4d3)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([732b15a](732b15a)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([77643e5](77643e5)) * **Notion Node:** Handle empty values correctly for Notion selects + multi selects ([#7383](#7383)) ([fbcd1d4](fbcd1d4)) * **Set Node:** Increase search priority ([#7358](#7358)) ([e5ad1e7](e5ad1e7)) * **Webhook Node:** Backward compatible form-data parsing for non-array files ([#7385](#7385)) ([6479eb1](6479eb1)) ### Features * **core:** Add Job Summary to Worker response ([#7360](#7360)) ([b8608ce](b8608ce)) * **core:** Integrate object store as binary data manager ([#7253](#7253)) ([1a661e6](1a661e6)) * **core:** Switch binary filesystem mode to nested path structure ([#7307](#7307)) ([0847623](0847623)) * **editor:** Make PDF and Audio binary-data viewable in the UI ([#7367](#7367)) ([8187be1](8187be1)) * **editor:** Support autologin for upgrade path ([#7316](#7316)) ([1dfa052](1dfa052)) * **Execute Workflow Node:** Run once for each item mode ([#7289](#7289)) ([c8c14ca](c8c14ca)) * **Item Lists Node:** Split merge binary data ([#7297](#7297)) ([965db8f](965db8f)) * **Loop Over Items (Split in Batches) Node:** Automatically add a loop + rename ([#7228](#7228)) ([7b773cc](7b773cc)) * **Notion Node:** Fetch child blocks recursively ([#7304](#7304)) ([193181a](193181a)) Co-authored-by: netroy <netroy@users.noreply.github.com>

⚡ GoogleSheets > read

1a5f2d2

michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Oct 3, 2023

michael-radency added 20 commits October 3, 2023 11:34

⚡ MySQL

d1131a3

Merge branch 'master' of https://github.com/n8n-io/n8n into node-802-…

fd5f06d

…check-paired-item-errors-for-operations-missing-pairing-info

⚡ Postgres

59a1647

⚡ Merge

6177e01

⚡ Filter and IF

15195c7

⚡ CompareDatasets

bca6110

⚡ MongoDB

beba706

Merge branch 'master' of https://github.com/n8n-io/n8n into node-802-…

9be0b34

…check-paired-item-errors-for-operations-missing-pairing-info

⚡ RssFeedRead

9b028c1

⚡ { item: 0 } fix

07e7d16

Merge branch 'master' of https://github.com/n8n-io/n8n into node-802-…

8a49d14

…check-paired-item-errors-for-operations-missing-pairing-info

⚡ Sheets, Set, PipeDrive

aad4cf5

⚡ GoogleSheet append update operation fix

ee52e3b

Merge branch 'master' of https://github.com/n8n-io/n8n into node-802-…

8607e20

…check-paired-item-errors-for-operations-missing-pairing-info

⚡ tests fix

e983740

Merge branch 'master' of https://github.com/n8n-io/n8n into node-802-…

465b286

…check-paired-item-errors-for-operations-missing-pairing-info

Merge branch 'master' of https://github.com/n8n-io/n8n into node-802-…

425a25f

…check-paired-item-errors-for-operations-missing-pairing-info

Merge branch 'master' of https://github.com/n8n-io/n8n into node-802-…

03b3a7a

…check-paired-item-errors-for-operations-missing-pairing-info

⚡ Hubspot, Kafka, MSQL, NextCloud, Wekan

2ccff6f

⚡ execute workflow

544f2cc

michael-radency changed the title ~~fix(core): Paired item errors for operations missing pairing info~~ fix(core): Missing pairing info Oct 5, 2023

maspio reviewed Oct 6, 2023

View reviewed changes

michael-radency added 2 commits October 8, 2023 06:56

⚡ review fix

08178cc

Merge branch 'master' of https://github.com/n8n-io/n8n into node-802-…

3a9abab

…check-paired-item-errors-for-operations-missing-pairing-info

maspio approved these changes Oct 10, 2023

View reviewed changes

michael-radency merged commit e2c3c7a into master Oct 10, 2023
54 of 55 checks passed

michael-radency deleted the node-802-check-paired-item-errors-for-operations-missing-pairing-info branch October 10, 2023 15:36

github-actions bot mentioned this pull request Oct 11, 2023

🚀 Release 1.11.0 #7402

Merged

janober added the Released label Oct 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): Missing pairing info #7326

fix(core): Missing pairing info #7326

michael-radency commented Oct 3, 2023

github-actions bot commented Oct 3, 2023

codecov bot commented Oct 3, 2023 •

edited

Loading

maspio Oct 6, 2023

maspio Oct 6, 2023

maspio Oct 6, 2023

cypress bot commented Oct 10, 2023

github-actions bot commented Oct 10, 2023

janober commented Oct 11, 2023

fix(core): Missing pairing info #7326

fix(core): Missing pairing info #7326

Conversation

michael-radency commented Oct 3, 2023

github-actions bot commented Oct 3, 2023

codecov bot commented Oct 3, 2023 • edited Loading

Codecov Report

maspio Oct 6, 2023

Choose a reason for hiding this comment

maspio Oct 6, 2023

Choose a reason for hiding this comment

maspio Oct 6, 2023

Choose a reason for hiding this comment

cypress bot commented Oct 10, 2023

2 flaky tests on run #2457 ↗︎

Review all test suite changes for PR #7326 ↗︎

github-actions bot commented Oct 10, 2023

janober commented Oct 11, 2023

codecov bot commented Oct 3, 2023 •

edited

Loading