Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Redis Sentinel support #5350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pemontto
Copy link
Contributor

@pemontto pemontto commented Feb 3, 2023

This PR adds Redis Sentinel support for HA using the underlying functionality of the ioredis library. It will connect to one of the supplied sentinels and get the current master. You can provide sentinels in a comma separated list in <host>:<port> format.

  1. Connecting to a Sentinel
  2. Getting the list of other Sentinels for redundancy
  3. Connecting to the current master node

image

Example config:

DEBUG=ioredis:* \
N8N_LOG_LEVEL=debug \
N8N_DIAGNOSTICS_ENABLED=false \
EXECUTIONS_MODE=queue \
QUEUE_BULL_REDIS_PASSWORD=passw0rd \
QUEUE_BULL_SENTINEL_ENABLED=true \
QUEUE_BULL_SENTINEL_SENTINELS="redis-sentinel-1:26379,redis-sentinel-2:26379,redis-sentinel-3:26379" \
./packages/cli/bin/n8n

You can also use a Sentinel password with QUEUE_BULL_SENTINEL_PASSWORD.

This is a first cut, I'm hoping to do more failure testing next week.

@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui labels Feb 3, 2023
@Joffcom
Copy link
Member

Joffcom commented Feb 9, 2023

Hey @pemontto,

Thanks for the PR 🙌🏻, I have created an internal ticket for the review which we will be tracking as N8N-6149

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Feb 9, 2023
@ghost
Copy link

ghost commented Feb 24, 2023

We would like to see this implemented as well.

@mickaelandrieu
Copy link
Contributor

Hi, any ETA for this feature ?

@Joffcom
Copy link
Member

Joffcom commented Aug 16, 2023

Hey @mickaelandrieu,

No ETA at the moment, we are about to start looking into scaling in more detail though so it could be soon if we decide to stick with this approach.

@the-nicolas
Copy link

Any update here?

We run a shared Redis-Sentinel Cluster for our services and want to migrate to it, instead of running dedicated Redis instances...

@HaddadJoe
Copy link

Same scenario as @the-nicolas, is there any help needed on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member core Enhancement outside /nodes-base and /editor-ui in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants