refactor(editor): Migrate FixedCollectionParameter to composition API #11555
Conversation
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
| this.mutableValues = deepCopy(this.values); | ||
| const locale = useI18n(); | ||
|
|
||
| const props = defineProps<{ |
There was a problem hiding this comment.
use withDefaults here to set the same default values as before. Just to be sure the component behaves exactly the same as before.
| parameter: INodeProperties; | ||
| path: string; | ||
| values: Record<string, INodeParameters[]>; | ||
| isReadOnly: boolean | undefined; |
There was a problem hiding this comment.
values and isReadOnly should be optional (they don't have required=true in defineComponent)
| return !!props.parameter.typeOptions?.multipleValues; | ||
| }); | ||
| const parameterOptions = computed(() => { | ||
| if (multipleValues && isINodePropertyCollectionList(props.parameter.options)) { |
| }>(); | ||
|
|
||
| const emit = defineEmits<{ | ||
| valueChanged: [value?: any]; |
There was a problem hiding this comment.
Specify a type for value. From usage I think it should be something like
type ValueChangedEvent = { path: string; value: NodeParameterValueType; type?: 'optionsOrderChanged'; }| } else { | ||
| newValue = newParameterValue; | ||
| } | ||
| let newValue; |
There was a problem hiding this comment.
If possible set a type for newValue, maybe NodeParameterValueType
| newValue = newParameterValue; | ||
| } | ||
| let newValue; | ||
| if (multipleValues) { |
| return props.parameter.options; | ||
| } | ||
|
|
||
| return (props.parameter.options as INodePropertyCollection[]).filter((option) => { |
There was a problem hiding this comment.
I think this type cast is avoidable by doing props.parameter.options ?? [], would be safer too 😄
Summary
This PR migrates FixedCollectionParameter to composition API
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)