refactor: Move runner types to runner package #11552
Merged
+378
−568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure the port is not already being listened
tomi
commented
Nov 5, 2024
| "import": "./src/start.ts", | ||
| "types": "./dist/start.d.ts" | ||
| }, | ||
| ".": { |
There was a problem hiding this comment.
Separate entrypoints for starting the task runner and importing code
|
|
||
| import type { RPC_ALLOW_LIST, TaskDataRequestParams, TaskResultData } from './runner-types'; | ||
|
|
||
| export namespace N8nMessage { |
There was a problem hiding this comment.
Moved from runner-types as is
| env: boolean; | ||
| } | ||
|
|
||
| export interface DataRequestResponse { |
|
|
||
| export type All = TaskSettings | TaskCancel | RPCResponse | TaskDataResponse | TaskRequest; | ||
| } | ||
| export interface TaskData { |
| | RPC | ||
| | TaskDataRequest; | ||
| } | ||
| export interface PartialAdditionalData { |
| @@ -34,230 +34,3 @@ export interface TaskRunnerServerInitRequest | |||
| } | |||
|
|
|||
| export type TaskRunnerServerInitResponse = Response & { req: TaskRunnerServerInitRequest }; | |||
|
|
|||
| export namespace N8nMessage { | |||
There was a problem hiding this comment.
Moved to runner-messages in @n8n/task-runner
| export interface TaskResultData { | ||
| result: INodeExecutionData[]; | ||
| customData?: Record<string, string>; | ||
| } | ||
|
|
||
| export namespace N8nMessage { |
There was a problem hiding this comment.
Moved to runner-messages
ivov
previously approved these changes
Nov 5, 2024
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
refactor-move-runner-types-to-runner-package
|
| Run status |
|
| Run duration | 04m 29s |
| Commit |
|
| Committer | Tomi Turtiainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
461
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move shared task runner types to task runner package.
Also small fix to tests:
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)