Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Change NodeOperationError default level to warning (no-changelog) #11542

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 4, 2024

Summary

Context

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@netroy netroy requested a review from ivov November 4, 2024 16:01
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! More of a chore(core) I'd say

@netroy netroy changed the title fix(core): Change NodeOperationError default level to warning (no-changelog) chore(core): Change NodeOperationError default level to warning (no-changelog) Nov 4, 2024
Copy link

cypress bot commented Nov 4, 2024

n8n    Run #7693

Run Properties:  status check passed Passed #7693  •  git commit ca65edaf67: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review change-NodeOperationError-level
Run status status check passed Passed #7693
Run duration 04m 36s
Commit git commit ca65edaf67: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 461
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Nov 4, 2024

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@netroy netroy merged commit 3eb05e6 into master Nov 4, 2024
34 checks passed
@netroy netroy deleted the change-NodeOperationError-level branch November 4, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants