feat(Monday.com Node): Check for error response #10654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
community
|
Hey @feelgood-interface, Thanks for the PR, We have created "GHC-201" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
n8n-assistant
bot
added
the
in linear
feelgood-interface
changed the title
|
|
feelgood-interface
force-pushed
the
master
branch
from
f405c35
to
a0af1d9
Compare
|
Sorry, I accidentally closed this issue when I rebased the upstream branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the response is not checked for any error.
responseDatawill have nodataproperty and therefore only anInternal errorwill be thrown (e.g. https://github.com/n8n-io/n8n/blob/e5c7534ebae0d7f42749f76270ca00eb49964d12/packages/nodes-base/nodes/MondayCom/MondayCom.node.ts#L541C6-L575C7).The response is now checked for any errors.
Related Linear tickets, Github issues, and Community forum posts
monday.com has 3 different error formats:
https://developer.monday.com/api-reference/docs/errors