Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Decouple Public API events from internal hooks (no-changelog) #10121

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jul 19, 2024

Follow-up to #10099

This is the first case of a shared event, please let me know if you agree with this or see a cleaner approach.

@ivov ivov marked this pull request as draft July 19, 2024 14:18
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 19, 2024
@ivov ivov removed the ui Enhancement in /editor-ui or /design-system label Jul 19, 2024
@ivov ivov marked this pull request as ready for review July 22, 2024 07:20
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the decoupling, I also like all the void on promises getting removed 🙌🏽

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit a7ae23b into master Jul 22, 2024
27 checks passed
@ivov ivov deleted the decouple-public-api-events-from-internal-hooks branch July 22, 2024 08:09
@janober
Copy link
Member

janober commented Jul 24, 2024

Got released with n8n@1.52.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants