refactor(core): Make browserId check mandatory #10120
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we added these checks in #9057, we kept the
browserId
field in the JWT optional to not force logout everyone en-masse.Now that it's been over 3 months, it's time to start enforcing this to prevent CSRF attacks on anyone who still has on old cookie (that's missing the
browserId
field)PS: This breaks the old auto-login from n8n cloud dashboard. I'll delete that code as well.
Related Linear tickets, Github issues, and Community forum posts
SEC-55
Review / Merge checklist