refactor(core): Make browserId check mandatory #10120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
force-pushed
the
SEC-55-make-browserId-mandatory
branch
from
1dd5cf4
to
e12ab2a
Compare
netroy
force-pushed
the
SEC-55-make-browserId-mandatory
branch
from
e12ab2a
to
961cdfe
Compare
|
This is blocked until we implement a new auto-login mechanism that uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we added these checks in #9057, we kept the
browserIdfield in the JWT optional to not force logout everyone en-masse.Now that it's been over 3 months, it's time to start enforcing this to prevent CSRF attacks on anyone who still has on old cookie (that's missing the
browserIdfield)PS: This breaks the old auto-login from n8n cloud dashboard. I'll delete that code as well.
Related Linear tickets, Github issues, and Community forum posts
SEC-55
Review / Merge checklist