fix(Notion Node): Fix issue preventing some database page urls from working #10070
Conversation
n8n-assistant
bot
added
n8n team
There was a problem hiding this comment.
@Joffcom Let me know if you've got any questions on this feedback, or would like an additional review after making changes. Thank you, JJ
packages/nodes-base/nodes/Notion/shared/descriptions/DatabasePageDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Notion/shared/descriptions/DatabasePageDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Notion/shared/descriptions/DatabasePageDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Notion/shared/descriptions/DatabasePageDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Notion/shared/descriptions/DatabasePageDescription.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Notion/shared/descriptions/DatabasePageDescription.ts
Outdated
Show resolved
Hide resolved
|
@jerzygangi are the recent changes any better? This now follows what Notion documents so for page ids we use a UUIDv4 and for database page you can use any UUID. I have also included your URL example in the tests. |
|
✅ All Cypress E2E specs passed |
3 flaky tests on run #6114 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #10070 ↗︎
|
Got released with |
|
@Joffcom Sorry, I'm a bit late replying. This regex looks solid -- also, the new unit tests with sample uuid's is smart. Can't wait for this commit hit n8n.cloud users. Separately, I wanted offer a 💯 emoji to you for the rapid turnaround time. I occasionally report bugs to startups, and it's amazing how many take months to reply & never fix the problem. After 1 or 2 ignored bug reports, I stop reporting. Conversely, the few engineering teams that do act quickly (like n8n) send a message to the customer that says "We value your time; we're building a quality product; please don't churn; we want your business." Keep up the hard work. |
|
Hello |
Summary
Fixes an issue with the RLC regex that was incorrectly flagging
https://www.notion.so/fake-instance/x-IDas invalid. Also added test forextractPageIdthat uses the regex pattern first.Related Linear tickets, Github issues, and Community forum posts
https://community.n8n.io/t/notion-update-by-url-not-working-for-guest-added-pages/50095