Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Update trim-fe-packageJson.js path in custom Dockerfile #10005

Conversation

adrian-martinez-onestic
Copy link
Contributor

Summary

Not sure if docker/images/n8n-custom/Dockerfile is still maintained, but just in case, after changes at aeac7b6 a path relative to a moved file needs to be changed accordingly.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@adrian-martinez-onestic adrian-martinez-onestic changed the title Update trim-fe-packageJson.js path in custom Dockerfile fix(custom Dockerfile): Update trim-fe-packageJson.js path in custom Dockerfile Jul 11, 2024
@adrian-martinez-onestic adrian-martinez-onestic changed the title fix(custom Dockerfile): Update trim-fe-packageJson.js path in custom Dockerfile fix(core): Update trim-fe-packageJson.js path in custom Dockerfile Jul 11, 2024
@n8n-assistant n8n-assistant bot added community Authored by a community member in linear Issue or PR has been created in Linear for internal review labels Jul 11, 2024
@netroy
Copy link
Member

netroy commented Jul 23, 2024

Sorry that this PR just went under the radar. We noticed the issue as well, and fixed it last week here.

Still Thanks for fixing it 🙇🏽 💟

@netroy netroy closed this Jul 23, 2024
@adrian-martinez-onestic adrian-martinez-onestic deleted the bugfix/update-custom-docker-image-script-path branch July 30, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants