Skip to content

Initial commit for respond-to-chat #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 28, 2025
Merged

Initial commit for respond-to-chat #3339

merged 9 commits into from
Jul 28, 2025

Conversation

pdwarf
Copy link
Collaborator

@pdwarf pdwarf commented Jul 9, 2025

Copy link

netlify bot commented Jul 9, 2025

Deploy Preview for n8n-docs ready!

Name Link
🔨 Latest commit b06a93c
🔍 Latest deploy log https://app.netlify.com/projects/n8n-docs/deploys/687e061de916f800089c872c
😎 Deploy Preview https://deploy-preview-3339--n8n-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@imchairmanm imchairmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pdwarf, thanks for the PR! It looks pretty good so far. I've left a few comments that might help. Additionally:

  • I spoke with David R. briefly about whether we should nest this within the Chat Trigger node or not. He had a really good point by asking how we do things with the Form node and Form Trigger node since those have the same type of relationship you describe here (The Form node depends on the Form Trigger node being present). Since we don't nest those, we should probably follow that pattern here and break this out into its own node page. I can do that once we're happy with the rest of the content if you agree that sounds reasonable.
  • I'll also need to add the page to the nav.yml file, so that it shows up in the site navigation. This is easy to do as I make the other changes, but for future reference, that's where you'd go to add the page to the site nav.
  • Do we have a current test instance I can look at? The one in the initial ticket has since been deleted. Probably best to share in Linear or Slack.

Let me know if you have any other questions about the suggestions or comments. Thanks again!

pdwarf and others added 6 commits July 18, 2025 13:37
…rigger/respondtochat.md

Co-authored-by: Justin Ellingwood <justin@n8n.io>
…rigger/respondtochat.md

Co-authored-by: Justin Ellingwood <justin@n8n.io>
…rigger/respondtochat.md

Co-authored-by: Justin Ellingwood <justin@n8n.io>
…rigger/respondtochat.md

Co-authored-by: Justin Ellingwood <justin@n8n.io>
…rigger/respondtochat.md

Co-authored-by: Justin Ellingwood <justin@n8n.io>
…rigger/respondtochat.md

Co-authored-by: Justin Ellingwood <justin@n8n.io>
@pdwarf
Copy link
Collaborator Author

pdwarf commented Jul 18, 2025

Hey @pdwarf, thanks for the PR! It looks pretty good so far. I've left a few comments that might help. Additionally:

  • I spoke with David R. briefly about whether we should nest this within the Chat Trigger node or not. He had a really good point by asking how we do things with the Form node and Form Trigger node since those have the same type of relationship you describe here (The Form node depends on the Form Trigger node being present). Since we don't nest those, we should probably follow that pattern here and break this out into its own node page. I can do that once we're happy with the rest of the content if you agree that sounds reasonable.
  • I'll also need to add the page to the nav.yml file, so that it shows up in the site navigation. This is easy to do as I make the other changes, but for future reference, that's where you'd go to add the page to the site nav.
  • Do we have a current test instance I can look at? The one in the initial ticket has since been deleted. Probably best to share in Linear or Slack.

Let me know if you have any other questions about the suggestions or comments. Thanks again!

Yeah that makes sense, happy to follow this convention for splitting it out and not nesting it! I've accepted all the suggestions and will add a bit more information as we've had to tweak the "Response Mode" of the Chat Trigger in lieu of the Respond to Chat node.

Copy link

Summary

Status Count
🔍 Total 15
✅ Successful 1
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 14
❓ Unknown 0
🚫 Errors 0
Full Github Actions output

@imchairmanm imchairmanm added the pending-dev Blocked pending merge of related dev PR label Jul 21, 2025
@imchairmanm
Copy link
Contributor

imchairmanm commented Jul 21, 2025

Thanks @pdwarf! We'll hold off on merging this until the PR is ready to go in the main repo.

@imchairmanm imchairmanm added in-next-release Follow-up to pending-dev. Use once the linked dev PR is merged. and removed pending-dev Blocked pending merge of related dev PR labels Jul 24, 2025
@imchairmanm
Copy link
Contributor

Holding off on merging until this is released.

@pdwarf pdwarf merged commit 897f93f into main Jul 28, 2025
7 checks passed
@pdwarf pdwarf deleted the respond-to-chat branch July 28, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-next-release Follow-up to pending-dev. Use once the linked dev PR is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants