-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add makefile #2917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add makefile #2917
Conversation
✅ Deploy Preview for n8n-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Summary
|
Overall readability score: 44.72 (🟢 +0)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
Looks promising - will have to test it out a few places |
@Joffcom couple of questions:
What's the benefit of using the Make file and adding another tool folks need to install? Happy to test it and use it if it's worth it. |
I think back when I added it there was some confusion on getting up and running, this gives us a consistent approach to it but would require make to be available. There may be a better way to handle this |
@Joffcom I'm torn because I'm aware using makefiles on Python projects is a pretty standard good practice. Equally, it's one more thing to install, and I'm wondering if we can just make the README / internal docs clearer? Either way we have to handle supporting OS differences (I don't think the current commands will activate venv on Windows, for instance) |
Adds a
Makefile
to check Python version, set up venv and install requirements, Also updates contributing guide to cover the new process.