Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docs for new credentials #2221

Merged
merged 26 commits into from
Sep 9, 2024
Merged

Adds docs for new credentials #2221

merged 26 commits into from
Sep 9, 2024

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jul 9, 2024

No description provided.

@Joffcom Joffcom added the pending-dev Blocked pending merge of related dev PR label Jul 9, 2024
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for n8n-docs ready!

Name Link
🔨 Latest commit 3b3cda2
🔍 Latest deploy log https://app.netlify.com/sites/n8n-docs/deploys/66a90e1813613e0008b2956c
😎 Deploy Preview https://deploy-preview-2221--n8n-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jul 9, 2024

Overall readability score: 42.13 (🔴 -0.09)

File Readability
datadog.md 15.72 (-)
dfiriris.md 22.69 (-)
dynatrace.md 14.59 (-)
elasticsecurity.md 57.12 (🟢 +8.92)
filescan.md 20.43 (-)
malcore.md 26.82 (-)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
datadog.md 15.72 0 11.33 22 19 10.2
  - - - - - -
dfiriris.md 22.69 3.93 10.31 20.2 19 9.59
  - - - - - -
dynatrace.md 14.59 0 11.35 22 19 10.54
  - - - - - -
elasticsecurity.md 57.12 34.83 7.83 13.2 15.23 6.61
  🟢 +8.92 🟢 +0.91 🟢 +2.3 🟢 +0.3 🟢 +0.13 🟢 +1.31
filescan.md 20.43 0 10.36 21.1 19 9.66
  - - - - - -
malcore.md 26.82 4.24 9.36 19 19 9.37
  - - - - - -

Averages:

  Readability FRE GF ARI CLI DCRS
Average 42.13 34.01 11.79 15.06 14.47 8.61
  🔴 -0.09 🔴 -0.14 🟢 +0.01 🔴 -0.02 🔴 -0.02 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

Copy link
Contributor

@freakwriter freakwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joffcom I added some suggested commits here, mostly to bold the GUI fields in n8n, sometimes to add some additional links to the provider's docs. I also already committed some changes to the Vale checking so it would stop throwing errors about Datadog, DFIR-IRIS and Malcore. Should be good to go if you accept the suggested commits.

Joffcom and others added 6 commits July 23, 2024 15:44
Co-authored-by: Kate Mueller <freakwriter@users.noreply.github.com>
Co-authored-by: Kate Mueller <freakwriter@users.noreply.github.com>
Co-authored-by: Kate Mueller <freakwriter@users.noreply.github.com>
Co-authored-by: Kate Mueller <freakwriter@users.noreply.github.com>
Co-authored-by: Kate Mueller <freakwriter@users.noreply.github.com>
Co-authored-by: Kate Mueller <freakwriter@users.noreply.github.com>
@Joffcom
Copy link
Member Author

Joffcom commented Jul 23, 2024

Thanks @freakwriter

Copy link
Contributor

@freakwriter freakwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the links to marketing integration pages are 404ing, but I'm assuming that's because the nodes haven't actually been released yet. Dynatrace did seem like it was out there though, so I added a comment in case that's just the wrong URL. Let me know if it's not and I can approve as-is.

I added contentType: integration into the frontmatter for all of these, since they should have it but it seemed silly to ask you to do that.

docs/integrations/builtin/credentials/dynatrace.md Outdated Show resolved Hide resolved
Copy link
Contributor

@freakwriter freakwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joffcom good to ship from my end!

@freakwriter freakwriter merged commit c7c9251 into main Sep 9, 2024
7 checks passed
@freakwriter freakwriter deleted the new-credentials branch September 9, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-dev Blocked pending merge of related dev PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants