Skip to content

Security Fix: Add explicit bounds check for numCoefficients in AudioFile library #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yannaingtun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security Fix: Add explicit bounds check for numCoefficients in AudioFile library #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tools/audiofile/audiofile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11183,7 +11183,11 @@ status WAVEFile::parseFormat(const Tag &id, uint32_t size)

/* numCoefficients should be at least 7. */
assert(numCoefficients >= 7 && numCoefficients <= 255);

if (numCoefficients < 7 || numCoefficients > 255)
{
_af_error(AF_BAD_HEADER, "Bad number of coefficients");
return AF_FAIL;
}
m_msadpcmNumCoefficients = numCoefficients;

for (int i=0; i<m_msadpcmNumCoefficients; i++)
Expand Down