-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Docker Support #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Took your Dockerfile and made some changes:
Feel free to use / ignore, shaves ~ 10% off the overall image size (mostly due to not installing git)
|
@streetster nice, much cleaner and safer with these changes. I incorporated your suggestions but left out the platform specific user ID changes. Those would not work on windows and don't make sense on mac, so I instead left a note about advanced usage & put it in the readme. |
Ah good point about UID on other platforms! Hope this PR gets merged as being able to build without polluting your local machine with a bunch of packages is always nice! |
I approve, I just hope I get some credit somehow. Good work guys. |
Thanks for your contribution! |
Merge pull request n64decomp#36 from ahouts/master
Merge camera-rebase into master. Good work :)
Add Docker config and update README
This PR
blatantly rips offbuilds upon the groundwork of #24 with the added benefit of having close to normal build times!Clean build
Cached build
This is accomplished by setting up the environment in the docker build, but only compiling during a run. As a result it only takes about a second to set up the environment and start compiling, meaning this could be used for development if one really wanted to.
Also the compiled files/rom are already in the host file system, no need to pull them out of the container.