Repository navigation
[DRAFT] Handle text_viewer '^' characters - #433
networkfusion wants to merge 1 commit into
Conversation
handle escape sequences (first attempt). Works towards n64brew#420
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe text viewer now doubles literal carets in file contents before passing them to the renderer. It checks the file position and reports errors if position lookup or expanded-buffer allocation fails. ChangesText viewer content handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change preserves literal carets in displayed files without interpreting them as formatting. No merge-blocking issue was identified; merge after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
handle escape sequences (first attempt).
Works towards #420
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
You agree with the license terms and that other license types may be granted with permission of the original
N64FlashcartMenuproject license holders.Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>
Summary by CodeRabbit
^) characters in text files now display as written instead of being interpreted as formatting escapes, so the viewer preserves the original text. This improves readability for files that contain carets and prevents their surrounding content from being unintentionally formatted.