Skip to content

Commit

Permalink
improve clarity of error message in case of wrong proxy server password
Browse files Browse the repository at this point in the history
why not be real user friendly and tell them where to get the password from and what the exact name of the password is. 
being not helpful just gives tinyproxy a bad name... ;-)
  • Loading branch information
n3mxnet authored Jun 28, 2019
1 parent 734ba1d commit 62c16c0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/reqs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1641,7 +1641,7 @@ void handle_connection (int fd)
failure = 0;
if(failure) {
e401:
update_stats (STAT_DENIED);
update_stats (STAT_DENIED);
indicate_http_error (connptr, 401, "Unauthorized",
"detail",
"The administrator of this proxy has not configured "
Expand All @@ -1651,7 +1651,7 @@ void handle_connection (int fd)
}
hashmap_remove (hashofheaders, "proxy-authorization");
}

/* above we should try to clarify it to even newbie users that their proxy password is what is wrong most likely here and actually tell him what to do about it. Those succint error msg drive ppl crazy */
/*
* Add any user-specified headers (AddHeader directive) to the
* outgoing HTTP request.
Expand Down

0 comments on commit 62c16c0

Please sign in to comment.