-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Generic Auth plugin #2281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5895172 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
💻 Website PreviewThe latest changes are available as preview in: https://a4016de4.envelop.pages.dev |
✅ Benchmark Results
|
ardatan
force-pushed
the
generic-auth-rework
branch
from
August 6, 2024 12:55
5a119b0
to
9b9885b
Compare
4 tasks
ardatan
force-pushed
the
generic-auth-rework
branch
2 times, most recently
from
August 12, 2024 20:34
fea7a5c
to
4355111
Compare
ardatan
force-pushed
the
generic-auth-rework
branch
from
August 26, 2024 10:32
c678176
to
5895172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Generic Auth plugin;
@auth
directive is renamed to@authenticated
. If you want to keep the old name you can configure the plugin to use the old name.directiveOrExtensionFieldName
is renamed toauthDirectiveName
.OBJECT
andINTERFACE
locations;validateUser
function does not receivefieldAuthDirectiveNode
andfieldAuthExtension
anymore. Instead, it takesfieldAuthArgs
which is an object that contains the arguments of the auth directive or extension. So you don't need to parse the arguments manually anymore.validateUser
'sobjectType
parameter is now renamed toparentType
. And it takes the original composite type instead of theGraphQLObjectType
instance. Now it can beGraphQLInterfaceType
as well.validateUser
's current parameters are now;@requiresScopes
and@policy
for more granular control over the auth logic.Check README for more information.