refactor: move runner config validation outside constructor

This allows lazy validation of the configuration. This is necessary for merging the runner configuration with the docker-compose configuration before validation.

src/index.ts

@@ -80,6 +80,7 @@ class Dockest {
     // Validate service name uniqueness
     const serviceMap: ObjStrStr = {}
     for (const runner of this.config.runners) {
+      runner.validateConfig()
       if (serviceMap[runner.runnerConfig.service]) {
         throw new ConfigurationError(
           `Service property has to be unique. Collision found for runner with service "${runner.runnerConfig.service}"`,

src/runners/@types.ts

@@ -62,6 +62,7 @@ export interface BaseRunner {
   initializer: string
   runnerConfig: RunnerConfig
   logger: Logger
+  validateConfig: () => void
 }
 
 export interface SharedRequiredConfigProps {

src/runners/GeneralPurposeRunner/index.spec.ts

@@ -14,6 +14,6 @@ describe('GeneralPurposeRunner', () => {
 
   it('should fail validation', () => {
     // @ts-ignore
-    expect(() => new GeneralPurposeRunner({})).toThrow(/service: Schema-key missing in config/)
+    expect(() => new GeneralPurposeRunner({}).validateConfig()).toThrow(/service: Schema-key missing in config/)
   })
 })

src/runners/GeneralPurposeRunner/index.ts

@@ -43,7 +43,9 @@ class GeneralPurposeRunner implements BaseRunner {
     }
 
     this.logger = new Logger(this)
+  }
 
+  public validateConfig() {
     const schema: { [key in keyof RequiredConfigProps]: any } = {
       service: validateTypes.isString,
     }

src/runners/KafkaRunner/index.spec.ts

@@ -33,6 +33,6 @@ describe('KafkaRunner', () => {
 
   it('should fail validation', () => {
     // @ts-ignore
-    expect(() => new KafkaRunner({})).toThrow(/service: Schema-key missing in config/)
+    expect(() => new KafkaRunner({}).validateConfig()).toThrow(/service: Schema-key missing in config/)
   })
 })

src/runners/KafkaRunner/index.ts

@@ -44,7 +44,9 @@ class KafkaRunner implements BaseRunner {
       ...config,
     }
     this.logger = new Logger(this)
+  }
 
+  public validateConfig() {
     const schema: { [key in keyof RequiredConfigProps]: any } = {
       service: validateTypes.isString,
     }

src/runners/PostgresRunner/index.spec.ts

@@ -26,7 +26,7 @@ describe('PostgresRunner', () => {
 
   it('should fail validation', () => {
     // @ts-ignore
-    expect(() => new PostgresRunner({ database: '_', password: '_', username: '_' })).toThrow(
+    expect(() => new PostgresRunner({ database: '_', password: '_', username: '_' }).validateConfig()).toThrow(
       /service: Schema-key missing in config/,
     )
   })

src/runners/PostgresRunner/index.ts

@@ -41,7 +41,9 @@ class PostgresRunner implements BaseRunner {
       ...configUserInput,
     }
     this.logger = new Logger(this)
+  }
 
+  public validateConfig() {
     // TODO: Can this type be generalized and receive RequiredConfigProps as an argument?
     const schema: { [key in keyof RequiredConfigProps]: () => void } = {
       database: validateTypes.isString,

src/runners/RedisRunner/index.spec.ts

@@ -14,6 +14,6 @@ describe('RedisRunner', () => {
 
   it('should fail validation', () => {
     // @ts-ignore
-    expect(() => new RedisRunner({})).toThrow(/service: Schema-key missing in config/)
+    expect(() => new RedisRunner({}).validateConfig()).toThrow(/service: Schema-key missing in config/)
   })
 })

src/runners/RedisRunner/index.ts

@@ -36,7 +36,9 @@ class RedisRunner implements BaseRunner {
       ...config,
     }
     this.logger = new Logger(this)
+  }
 
+  public validateConfig() {
     const schema: { [key in keyof RequiredConfigProps]: any } = {
       service: validateTypes.isString,
     }

src/runners/ZooKeeperRunner/index.spec.ts

@@ -14,6 +14,6 @@ describe('ZooKeeperRunner', () => {
 
   it('should fail validation', () => {
     // @ts-ignore
-    expect(() => new ZooKeeperRunner({})).toThrow(/service: Schema-key missing in config/)
+    expect(() => new ZooKeeperRunner({}).validateConfig()).toThrow(/service: Schema-key missing in config/)
   })
 })

src/runners/ZooKeeperRunner/index.ts

@@ -34,7 +34,9 @@ class ZooKeeperRunner implements BaseRunner {
       ...config,
     }
     this.logger = new Logger(this)
+  }
 
+  public validateConfig() {
     const schema: { [key in keyof RequiredConfigProps]: any } = {
       service: validateTypes.isString,
     }