Skip to content

fix invalid comparison causing errors opening frame #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix invalid comparison causing errors opening frame #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions v2/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
package id3v2

import (
"bytes"
"errors"
"fmt"
"io"
Expand Down Expand Up @@ -145,17 +146,17 @@ func parseFrameHeader(buf []byte, rd io.Reader, synchSafe bool) (frameHeader, er
return header, err
}

id := string(fhBuf[:4])
id := fhBuf[:4]
bodySize, err := parseSize(fhBuf[4:8], synchSafe)
if err != nil {
return header, err
}

if id == "" || bodySize == 0 {
if bytes.Equal(id, []byte{0, 0, 0, 0}) || bodySize == 0 {
return header, errBlankFrame
}

header.ID = id
header.ID = string(id)
header.BodySize = bodySize
return header, nil
}
Expand Down