VIRA-253: slow performance

[chinwobble]

As a user, I don't want an open VIRA report to be slow and I don't want each report to take a long time to load.

I suspect something is wrong with the async code.

I'm going to put a few examples of how to profile the python and vim code.

• Override timeout for async updates
• Error after message and issue create (VIRA-247) [d846711]
  • c03487c was the last good one?!?
    • leads to menu layout again...
  • OoO demands tabs win...
  • I got "lucky" and had seen a flash that a second .vira_prompt is open on the fly and we need strings and numbers to work properly
  • One more test
  • I will need to go through the list again. This appears to fix the menus but I lost the fix for it.
• Fold lost (VIRA-221) [31c6fec]
• Refresh report goes blank (VIRA-213) [627b6c4]

profile python code

function! vira#_print_report(list) " {{{2
  " Write report output into buffer
  python3 << EOF
import vim
import cProfile
with cProfile.Profile() as pr:
  report = Vira.api.get_report().splitlines()
  vim.current.buffer.append(report)
pr.dump_stats('/tmp/vira_print_report.dmp')

EOF
endfunction

Then i use snakeviz to check the results.

[n0v1c3]

Please note pycontribs/jira#622 from our README as well. Not directly related on the connection but worth a look.

[n0v1c3]

I do no not have any major delays though.

[n0v1c3]

I know I broke quite a bit getting it working backwards but it was still very worth it.

[n0v1c3]

Regarding the snakeviz package. Using it to test is fine. We would need to make a good plane to make something like that long term.

We even needed to fold with yaml and that is just because @mikeboiko and @n0v1c3 like it.

[n0v1c3]

Older Comments was also broken between the following comets.

| * | 31c6fec VIRA-221: Fixed bug where opening menu/report cleared clipboard
| * | d3bbbbc Fixed dictionary merging bug using deepcopy()

[chinwobble]

I commented out this code and its fast again.

function! vira#_async() abort "{{{2
  " try
  "   python3 Vira.api._async(Vira.api._async_vim)
  " endtry
  " if s:vira_async_debug | echo s:versions | endif
  call timer_start(s:vira_async_timer, { -> execute('call vira#_async()', '') })
endfunction

I think you can test on your own server by creating hundreds of new versions.

[chinwobble]

This is the vim profile I get when I just have the vira_report open. This does not include connecting or print_report.

FUNCTIONS SORTED ON SELF TIME
count  total (s)   self (s)  function
    8             13.436866  vira#_async()
  221   0.081763   0.054034  fugitive#Find()
  442   0.050392   0.029758  airline#extensions#ale#get()
  221   0.040925   0.027166  airline#check_mode()
 1547              0.017236  airline#util#append()
 2210   0.015839   0.013823  airline#util#wrap()
  221   0.014205   0.012562  <SNR>92_update_hg_branch()
  442   0.014639   0.012370  FugitiveGitDir()
  667   0.018845   0.012113  airline#util#shorten()
  221   0.140207   0.011385  <SNR>92_update_branch()
  221   0.093052   0.011289  fugitive#Head()
  442              0.011046  airline#extensions#coc#get()
  112   0.011688   0.010708  <SNR>74_Highlight_Matching_Pair()
  128   0.010266   0.009734  <SNR>56_notify()
  221   0.010510   0.009663  airline#extensions#fugitiveline#bufname()
  896              0.008813  airline#util#winwidth()
  221              0.007909  airline#extensions#keymap#status()
  221   0.163484   0.007854  airline#extensions#branch#get_head()
    1   0.007846   0.007837  ctrlp#utils#writecache()
  121   0.010140   0.007310  ale#cursor#EchoCursorWarningWithDelay()

[n0v1c3]

If you are shutting it right off I would try setting init and timer quite high in ms.

@mikeboiko and I are looking for a way around their extra lag bugs as well.

[n0v1c3]

Also have you tried to comment out the one mentioned above?

[chinwobble]

I think to implement true async, we need to use the job and channels api in vim.
Here is an example I found.
https://github.com/OmniSharp/omnisharp-vim/blob/03f8fd4c88d1d5447da55ec499f2ca563e7e54d0/autoload/OmniSharp/proc.vim#L4
https://vimhelp.org/channel.txt.html

[n0v1c3]

Probably smoother and cleaner.

[n0v1c3]

@chinwobble you should also be able to try:

let g:vira_async_timer = 30000
let g:vira_async_timer_init = 30000

That should be 30s apart. Worth a test with tack away the python time.

[chinwobble]

I just did a quick test, this doesn't block or lag the ui.

let s:save_cpo = &cpoptions
set cpoptions&vim

let s:jobs = get(s:, 'jobs', [])
let s:channels = get(s:, 'channels', [])

function! proc#EchoErr(channel, msg)
      let v:errmsg = a:msg
      echohl ErrorMsg | echomsg a:msg | echohl None
      echom a:channel
endfunction

function! proc#run_job(msg)
      let job = job_start(
                        \ ['python', '-c', 'import time; time.sleep(10); print("hello")'],
                        \ {'callback': 'proc#EchoErr'})
      call add(s:jobs, job)
      " let channel = job_getchannel(job)

endfunction