test(proto): Never allow constructing empty packets#451
Draft
test(proto): Never allow constructing empty packets#451
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/451/docs/noq/ Last updated: 2026-03-04T08:36:21Z |
Performance Comparison Report
|
| Scenario | iroh-quinn | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5939.5 Mbps | 7911.8 Mbps | -24.9% | 97.4% / 99.0% |
| medium-concurrent | 5591.9 Mbps | 7126.0 Mbps | -21.5% | 96.2% / 98.0% |
| medium-single | 3876.9 Mbps | 4189.1 Mbps | -7.5% | 95.8% / 98.3% |
| small-concurrent | 3702.4 Mbps | 5110.9 Mbps | -27.6% | 95.6% / 98.1% |
| small-single | 3575.7 Mbps | 4402.5 Mbps | -18.8% | 96.1% / 98.5% |
Netsim Benchmarks (network simulation)
| Condition | iroh-quinn | upstream | Delta |
|---|---|---|---|
| ideal | 2964.6 Mbps | 4052.5 Mbps | -26.8% |
| lan | 782.4 Mbps | 810.4 Mbps | -3.4% |
| lossy | 69.8 Mbps | 69.9 Mbps | ~0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
iroh-quinn is 21.2% slower on average
717471daff3e14d82788d78bbd7506ac0e6c498a - artifacts
Raw Benchmarks (localhost)
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5443.9 Mbps | 8193.1 Mbps | -33.6% | 93.5% / 98.2% |
| medium-concurrent | 5465.5 Mbps | 7678.5 Mbps | -28.8% | 93.7% / 100.0% |
| medium-single | 3586.7 Mbps | 4790.4 Mbps | -25.1% | 99.6% / 186.0% |
| small-concurrent | 3854.8 Mbps | 4982.0 Mbps | -22.6% | 97.0% / 127.0% |
| small-single | 3567.0 Mbps | 4861.3 Mbps | -26.6% | 86.0% / 95.7% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 2921.6 Mbps | 4022.9 Mbps | -27.4% |
| lan | 782.4 Mbps | 810.4 Mbps | -3.5% |
| lossy | 55.9 Mbps | 55.9 Mbps | ~0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 27.4% slower on average
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
debug_assert!that checks for the case in #176This allows us to generate minimal proptest failures (and other test failures) for when this happens.
This happens all the time.
Notes & open questions
This PR doesn't fix this problem yet. Just adds a test case. Thus draft.
There might be a better/easer/more correct way to check this than what I'm doing here with checking
SentPackets, and instead somehow look at whether bytes were written toPacketBuilder::buf, but I admit I don't understand what's going on with the buffer and all the offsets enough to make the correct check for this possible.