Skip to content

test: panic in Connection::pto_max_path#390

Draft
Arqu wants to merge 2 commits intomainfrom
arqu/test_panic
Draft

test: panic in Connection::pto_max_path#390
Arqu wants to merge 2 commits intomainfrom
arqu/test_panic

Conversation

@Arqu
Copy link
Collaborator

@Arqu Arqu commented Feb 1, 2026

Description

Breaking Changes

Notes & open questions

@github-actions
Copy link

github-actions bot commented Feb 1, 2026

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/390/docs/iroh_quinn/

Last updated: 2026-02-01T07:29:59Z

@github-actions
Copy link

github-actions bot commented Feb 1, 2026

Performance Comparison Report

7ef56188d16c766530042410bee2292c4c572a7a - artifacts

Raw Benchmarks (localhost)

Scenario iroh-quinn upstream Delta CPU (avg/max)
large-single 5357.5 Mbps 7910.4 Mbps -32.3% 91.1% / 96.5%
medium-concurrent 5338.4 Mbps 7592.0 Mbps -29.7% 88.8% / 96.1%
medium-single 3705.3 Mbps 3966.1 Mbps -6.6% 98.1% / 177.0%
small-concurrent 3670.1 Mbps 5070.3 Mbps -27.6% 98.1% / 122.0%
small-single 3179.0 Mbps 4275.9 Mbps -25.7% 84.6% / 95.2%

Netsim Benchmarks (network simulation)

Condition iroh-quinn upstream Delta
ideal 2965.6 Mbps 3743.2 Mbps -20.8%
lan 782.5 Mbps 796.3 Mbps -1.7%
lossy 69.8 Mbps 55.9 Mbps +25.0%
wan 83.8 Mbps 83.8 Mbps ~0%

Summary

iroh-quinn is 24.9% slower on average

@n0bot n0bot bot added this to iroh Feb 1, 2026
@github-project-automation github-project-automation bot moved this to 🚑 Needs Triage in iroh Feb 1, 2026
@dignifiedquire dignifiedquire moved this from 🚑 Needs Triage to 👀 In review in iroh Feb 3, 2026
@flub
Copy link
Collaborator

flub commented Feb 4, 2026

Is this a draft? Is it still relevant given that #366 was already merged?

@matheus23
Copy link
Member

The regression test in here is kinda neat. Perhaps it's worth removing the other unrelated changes, removing the should_panic from the test and then merging this.

@flub flub marked this pull request as draft February 12, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

3 participants