feat: qlog support in iroh #3698
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3698/docs/iroh/ Last updated: 2025-11-25T10:16:16Z |
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
Generally lgtm. Would be cool to see if testdir works well with this, but not required.
Needs to wait till the stuff is merged in Quinn.
There was a problem hiding this comment.
Changes here should be removed by the time things are ready to be merged.
| impl QlogFileGroup { | ||
| /// Creates a new [`QlogFileGroup] that is only enabled if feature flags and environment variables match. | ||
| /// | ||
| /// The qlog files will be written to `CARGO_MANIFEST_DIR/qlog`. |
There was a problem hiding this comment.
Time to advertise https://crates.io/crates/testdir again. :)
Would be cool if we can use that by default.
There was a problem hiding this comment.
Also makes me notice "[`QlogFileGroup]" has messed up markup
|
|
||
| /// Creates a [`TransportConfig`] that emits qlog files with a server vantage point, if enabled. | ||
| /// | ||
| /// If the "qlog" feature is enabled, and the environment varialbe IROH_TEST_QLOG is set to "1", |
There was a problem hiding this comment.
1 is a very specific value. Why not just "not empty"?
Description
This adds
qlogsupport to iroh. Depends on n0-computer/quinn#181.Test it out:
You'll find two files in
iroh/qlog. Go to https://qvis.quictools.info/ and import both files (you can select multiple). Then click on sequence and select client and server on left and right.Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme