fix: handle invalid input length when parsing a node id #3155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a panic when calling `decode_mut` with an invalid input length. Closes #3153
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3155/docs/iroh/ Last updated: 2025-01-28T10:50:06Z |
matheus23
approved these changes
Jan 28, 2025
Member
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
Very annoying that decode_mut panics... seems like a footgun.
|
Thanks! |
4 tasks
rklaehn
added a commit
to n0-computer/iroh-blobs
that referenced
this pull request
Mar 11, 2025
## Description Same issue as n0-computer/iroh#3155 ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented. --------- Co-authored-by: Ruediger Klaehn <rklaehn@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a panic when calling
decode_mutwith an invalid input length.Closes #3153