refactor(iroh)!: Move blobs and tags rpc client and server to iroh-blobs #2874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2874/docs/iroh/ Last updated: 2024-11-06T16:15:38Z |
rklaehn
force-pushed
the
move-blobs-rpc
branch
from
d596522 to
6e66ef4
Compare
rklaehn
commented
Oct 31, 2024
| @@ -28,8 +29,7 @@ use iroh::{ | |||
| }, | |||
| client::{ | |||
| blobs::{ | |||
| BlobInfo, BlobStatus, CollectionInfo, DownloadMode, DownloadOptions, | |||
| IncompleteBlobInfo, WrapOption, | |||
| BlobInfo, BlobStatus, CollectionInfo, DownloadOptions, IncompleteBlobInfo, WrapOption, | |||
There was a problem hiding this comment.
This will probably go away if docs are removed as well.
|
what about removing the fs utils you added to |
I think some of them are also used from docs, so I can't remove them all until docs are also gone... But will check. |
# Conflicts: # Cargo.lock # iroh-cli/Cargo.toml # iroh-dns-server/src/http/rate_limiting.rs # iroh/Cargo.toml
rklaehn
force-pushed
the
move-blobs-rpc
branch
2 times, most recently
from
d96c6c2 to
914452c
Compare
Removed several, including stuff that needs walkdir. But there is still something left that is needed from docs. |
dignifiedquire
approved these changes
Nov 6, 2024
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
…obs (#2874) ## Description Move blobs and tags rpc client and server to iroh-blobs. Depends on n0-computer/iroh-blobs#7 Todo: - [x] merge n0-computer/iroh-blobs#7 ## Breaking Changes - Lots of types in client::blobs and client::tags become reexports - blob share goes away, since it requires the node client ## Notes & open questions I want to keep the client::blobs and client::tags modules self-contained, so the idea is that these will reexport all the things from iroh-blobs::rpc::client that a user will need (except I have probably forgotten something). Maybe I should use wildcard exports here even though people dislike them... ? ~~The client::blobs::Client itself is *not* a reexport but a newtype to hide the ugly type parameters. Same for client::tags::Client.~~ With the changes in quic-rpc, these are now just module reexports! The Blobs protocol handler now takes an Endpoint, since that was needed to implement one of the functions. <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [x] Tests if relevant. - [x] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move blobs and tags rpc client and server to iroh-blobs.
Depends on n0-computer/iroh-blobs#7
Todo:
Breaking Changes
Notes & open questions
I want to keep the client::blobs and client::tags modules self-contained, so the idea is that these will reexport all the things from iroh-blobs::rpc::client that a user will need (except I have probably forgotten something). Maybe I should use wildcard exports here even though people dislike them... ?
The client::blobs::Client itself is not a reexport but a newtype to hide the ugly type parameters. Same for client::tags::Client.With the changes in quic-rpc, these are now just module reexports!
The Blobs protocol handler now takes an Endpoint, since that was needed to implement one of the functions.
Change checklist